Re: that.. https://www.spinics.net/lists/fedora-devel/msg274669.html
Quote from an Igor: <quote> I'm confused by the proposal, it is named "CMake to do out-of-source builds" but the macros seems to do the opposite? On Rawhide (local repo): %__cmake \ -S "%{_vpath_srcdir}" \ -B "%{__cmake_builddir}" \ __cmake_builddir %{!?__cmake_in_source_build:%{_vpath_builddir}}%{?__cmake_in_source_build:.} __cmake_in_source_build 1 Looks like __cmake_builddir is defined as "." so the build will happen in source? </quote> On Mon, 20 Jul 2020 at 23:45, Nick Østergaard <oe.n...@gmail.com> wrote: > > I am not sure I misunderstand the terminology here, but "cmake -S . -B > foo -Dnickersej" looks "in tree" to me. > > On Mon, 20 Jul 2020 at 23:37, Seth Hillbrand <s...@kipro-pcb.com> wrote: > > > > Hi Steve- > > > > This looks like a build setup issue, not in our CMake code. We can > > build out of tree (in fact, we really prefer it) right now. From the > > log, the broken command is > > /usr/bin/cmake -S . -B x86_64-redhat-linux-gnu > > -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG > > -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG > > -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG > > -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr > > -DINCLUDE_INSTALL_DIR:PATH=/usr/include > > -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc > > -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 > > -DBUILD_SHARED_LIBS:BOOL=ON -DKICAD_SCRIPTING=ON > > -DKICAD_SCRIPTING_MODULES=ON -DKICAD_SCRIPTING_PYTHON3=ON > > -DKICAD_SCRIPTING_WXPYTHON=ON -DKICAD_SCRIPTING_WXPYTHON_PHOENIX=ON > > -DKICAD_SCRIPTING_ACTION_MENU=ON -DKICAD_USE_OCC=ON > > -DKICAD_INSTALL_DEMOS=ON -DKICAD_BUILD_QA_TESTS=OFF > > -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SPICE=ON > > -DKICAD_VERSION_EXTRA=r19086-6d8fb94d -DCMAKE_BUILD_TYPE=Debug . > > > > You can modify this in your .spec.template file. > > > > Best- > > Seth > > > > Seth Hillbrand > > KiCad Services Corporation > > https://www.kipro-pcb.com > > +1 530 302 5483 | +1 212 603 9372 > > > > On 2020-07-20 14:28, Steven A. Falco wrote: > > > Fedora recently made a change to their cmake macros, to force packages > > > to build "out of tree". The developers responsible for this change > > > plan to go through and fix up the thousand or so packages that may > > > break as a result, so they should eventually fix the official > > > downstream KiCAD package. > > > > > > However, they will not be able to fix up third-party packages, one of > > > which is our nightly builds. > > > > > > The attached email shows that KiCAD does indeed fail to build for > > > Fedora rawhide now. The right thing to do is to modify the > > > kicad.spec.template file to accommodate the new cmake macros, but as a > > > temporary workaround, we can add a line to force the old behavior: > > > > > > %global __cmake_in_source_build 1 > > > > > > I've tried that, and it does let KiCAD build as before. > > > > > > I don't know exactly how the developers plan to fix up the broken > > > packages, so we can either add the workaround, wait to see what they > > > do, then change the nightlies to match (and remove the workaround), OR > > > we can make our own changes, which may result in the spec files > > > diverging. > > > > > > If the lead KiCAD devs wish, I can add the workaround - I can do that > > > quickly. Attempting to sort out a proper fix would naturally take > > > longer. > > > > > > Steve > > > > > > > > > > > > _______________________________________________ > > > Mailing list: https://launchpad.net/~kicad-developers > > > Post to : kicad-developers@lists.launchpad.net > > > Unsubscribe : https://launchpad.net/~kicad-developers > > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : kicad-developers@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp