Hi Simon, On 1/6/20 8:59 AM, Simon Richter wrote: > Hi, > > On Mon, Jan 06, 2020 at 05:16:30AM -0800, Seth Hillbrand wrote: > >>> Apparently development versions also generate output with whitespace >>> errors and, in one case, compute a size differently, that might also be >>> interesting to watch in the future. > >> I'm not really concerned about the warning, dire as it is worded. >> However, I would like to know which dialog was sized differently. >> One of the reasons we were OK with development versions is that >> wxformbuilder is so buggy that 3.8.0 was not useable for certain >> controls. > > Regenerating pcbnew/dialogs/dialog_text_properties_base.fbp with 3.9.0 > gives a different default size (height 563 instead of 463) compared with > the unreleased version it was generated before.[1]
This is a KiCad bug. The default dialog size should be -1, -1 or wxDefaultSize per the UI Guidelines[1]. Setting a default dialog size interferes with the sizers correctly doing there job in some (all?) cases so I'm less concerned about the difference between wxFormbuilder versions than I am about the fact that the dialog has a hard coded size. [1]: https://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html#dialogs-sizers > > (I know the patch says 3.8.0 -- my Debian package hardcoded that, and I > didn't fix it before rebuilding, but this is the state from the 3.9.0 > release) > > Simon > > [1] > https://gitlab.com/kicad/code/kicad/merge_requests/45/diffs#b56671c731bede3525b64ef8f4780a86125d86c5 > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
