Hi Franck, Please remember to add changelog tags [1] when sending patch v4. Thanks!
Cheers, Orson 1. http://docs.kicad-pcb.org/doxygen/commit_messages.html On 11/10/19 7:36 PM, Franck Jullien wrote: > Le dim. 10 nov. 2019 à 18:29, jp charras <jp.char...@wanadoo.fr> a écrit : >> >> Le 10/11/2019 à 17:33, Franck Jullien a écrit : >>> Le jeu. 7 nov. 2019 à 21:51, <franck.jull...@gmail.com> a écrit : >>>> >>>> From: Franck Jullien <franck.jull...@gmail.com> >>>> >>>> User can now decide to keep the hierarchy navigator open while working >>>> on a schematic. This behavior can be configured in >>>> eeschema->preferences->eeschema->Editing options. >>>> >>>> Signed-off-by: Franck Jullien <franck.jull...@gmail.com> >>>> --- >>>> >>>> v2: fix coding style >>>> v3: fix memory leak after Wayne review >>> >>> I need to work on it again. If the navigator stays open and you add a >>> new page, the hierarchy is not updated. >>> I'll be back with a v4 :) >>> >>> Franck. >> >> Hi Franck, >> >> This is the main problem with not modal dialogs: they have to take in >> account changes made in an other frame, and this is not always easy. >> >> (Here: adding/renaming/deleting a hierarchical sheet) >> >> Remember: your patches must be in a attached file. >> Patch texts inside a mail cannot be used (are broken for patch utilities). > > I didn't know patch must be attached. Moving to gitlab will be awsome :) > I'm sending a v4 now. Hopefully this is the last one. > > Merci. > > Franck. > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
