Adam, I took a look at this patch set and I have some concerns. The CMake changes seem acceptable but I'm curious as to why you had to add all of the python paths in pcbnew.cpp to get Python working under macos. Does Python on macos not look in the install path for library paths like it does on other platforms. If we have to do this to get python to work on macos, then at the very least we should at least not hard code the python version in the path strings and use a CMake configuration variable to generate them. That way we wont have to modify pcbnew.cpp every time we update to a new version of python on macos. Would one of our macos devs please take a look at this and work with Adam so we can come up with a solution so we don't have unknown git commit hashes in our version strings.
Thanks, Wayne On 9/5/19 11:45 AM, Adam Wolf wrote: > It would be awesome to have them merged into upstream. They're all > very packaging specific. > > Here is the current list: > > * > https://github.com/KiCad/kicad-mac-builder/tree/master/kicad-mac-builder/patches/kicad > > Adam Wolf > > On Thu, Sep 5, 2019 at 8:19 AM Jeff Young <j...@rokeby.ie> wrote: >> >> Yeah, it would be -really- nice if we could fix this somehow. I’ve run into >> it many times. >> >> Cheers, >> Jeff. >> >> >>> On 5 Sep 2019, at 14:07, Jonatan Liljedahl <li...@kymatica.com> wrote: >>> >>> On Thu, Sep 5, 2019 at 1:59 PM Nick Østergaard <oe.n...@gmail.com> wrote: >>>> >>>> Does the sha listed in the version info from the runtime app not match? >>> >>> Unfortunately not. For example (5.1.4-60-ga2950354a) >>> >>> lijon-mbp:kicad lijon$ git branch >>> * 5.1 >>> master >>> lijon-mbp:kicad lijon$ git log --oneline | grep ga2950354a >>> lijon-mbp:kicad lijon$ >>> >>> >>> -- >>> /Jonatan >>> http://kymatica.com >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
