The pin should have a SCH_PIN_CONNECTION (via SCH_COMPONENT:: m_pin_connections) which has a SCH_CONNECTION which is where the connectivity info is stored. You want SCH_CONNECTION::Name() to get you the final netname.
On Mon, Apr 1, 2019 at 5:15 PM Jeff Young <j...@rokeby.ie> wrote: > Name() appears to only be on SHEET_PINs though. Or did I misread that? > > On 1 Apr 2019, at 22:08, Jon Evans <j...@craftyjon.com> wrote: > > Hi Jeff, > > You can call Name() on the connection object for the current sheet -- see > SCH_EDIT_FRAME::HighlightConnectionAtPosition() for some reference code. > GetDefaultNetName does not include the sheet path as it only returns > candidate net names for pins, not the final net names used for netlisting. > > -Jon > > On Mon, Apr 1, 2019 at 5:02 PM Jeff Young <j...@rokeby.ie> wrote: > >> Hi Jon, >> >> I’m trying to integrate the pin highlighting stuff with your merge. I’ve >> added some code to SCH_EDIT_FRAME::SetCurrentSheetHighlightFlags() which >> attempts to use the pin’s connection to see if it should be highlighted. >> >> However, I’m having two issues. >> >> 1) Is there a way to get the current netname? I found >> GetDefaultNetName(), but that will only get the name that will be pushed >> from that pin, not the actual netname. >> 2) When I do get a name it’s missing the beginning ‘/‘. But maybe that’s >> just because I’m calling the wrong routine. >> >> Thanks, >> Jeff. >> >> >> On 1 Apr 2019, at 13:34, Jon Evans <j...@craftyjon.com> wrote: >> >> Speaking of that, if anyone wants to be adventurous, you can test >> real-time by defining CONNECTIVITY_REAL_TIME and CONNECTIVITY_PROFILE. >> In my testing, it is so fast as to be seamless on most machines with most >> designs. >> There are a few edge cases where the regeneration can take longer, >> especially on debug builds. >> >> I'm interested in collecting profile data (using perf or some other >> similar tool) from machines where this feature is annoyingly slow. >> My goal would be to enable it when the performance penalty is no more >> than ~100-150ms worst case in debug mode for real-time operations. >> >> Thanks, >> Jon >> >> On Mon, Apr 1, 2019 at 7:37 AM Wayne Stambaugh <stambau...@gmail.com> >> wrote: >> >>> No problem. I wanted to get this merged so we can get some additional >>> testing. Hopefully you will be able to resolve the performance issues >>> so we can have real time netlist generation and some of the nifty >>> features that this will allow. >>> >>> On 3/31/2019 11:19 PM, Jon Evans wrote: >>> > Thanks Wayne! Everything looks good to me. >>> > >>> > Glad to finally have this merged so that I can start building other >>> > improvements on top of it. >>> > >>> > On Sun, Mar 31, 2019 at 9:42 PM Wayne Stambaugh <stambau...@gmail.com >>> > <mailto:stambau...@gmail.com>> wrote: >>> > >>> > Jon, >>> > >>> > I forgot to mention. Please take a look and make sure I didn't >>> muck >>> > anything up when you get a chance. >>> > >>> > Wayne >>> > >>> > On 3/31/19 9:38 PM, Wayne Stambaugh wrote: >>> > > Jon, >>> > > >>> > > I merged your patch set into the master branch. Thank you for >>> all of >>> > > your efforts. >>> > > >>> > > Cheers, >>> > > >>> > > Wayne >>> > > >>> > > On 3/31/19 7:50 PM, Jon Evans wrote: >>> > >> Yes I just squashed the parts that dont compile on their own. >>> > >> >>> > >> On Sun, Mar 31, 2019, 19:48 Wayne Stambaugh < >>> stambau...@gmail.com >>> > <mailto:stambau...@gmail.com> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>> >>> wrote: >>> > >> >>> > >> Jon, >>> > >> >>> > >> I thought we decided to squash your patch set or did you >>> just >>> > squash >>> > >> part of the patch set? I see 17 separate patches the >>> archive >>> > you >>> > >> sent. >>> > >> >>> > >> Wayne >>> > >> >>> > >> On 3/31/19 7:39 PM, Jon Evans wrote: >>> > >> > Attached! >>> > >> > >>> > >> > On Sun, Mar 31, 2019 at 7:28 PM Wayne Stambaugh >>> > >> <stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>> >>> > >> > <mailto:stambau...@gmail.com <mailto: >>> stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>>> >>> > >> wrote: >>> > >> > >>> > >> > Jon, >>> > >> > >>> > >> > Would you please post the squashed patch to the >>> > mailing list >>> > >> so I can >>> > >> > get it merged? >>> > >> > >>> > >> > Thanks, >>> > >> > >>> > >> > Wayne >>> > >> > >>> > >> > On 3/31/19 3:07 PM, Jon Evans wrote: >>> > >> > > I went through and squashed the offending commits >>> and >>> > >> updated the >>> > >> > PRs. >>> > >> > > >>> > >> > > -Jon >>> > >> > > >>> > >> > > On Sun, Mar 31, 2019 at 2:22 PM Wayne Stambaugh >>> > >> > <stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>> >>> > >> > > <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com> <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com>> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>>>> >>> wrote: >>> > >> > > >>> > >> > > If that's the case then it may make the most >>> > sense to >>> > >> squash >>> > >> > everything >>> > >> > > into a single commit. >>> > >> > > >>> > >> > > On 3/31/19 2:17 PM, Jon Evans wrote: >>> > >> > > > That one was very late and would be easy to >>> > squash. >>> > >> > However, some >>> > >> > > of the >>> > >> > > > very early commits in the branch were split >>> > up for >>> > >> review >>> > >> > > purposes and >>> > >> > > > not intended to be built on their own. >>> > >> > > > >>> > >> > > > On Sun, Mar 31, 2019, 14:16 Wayne Stambaugh >>> > >> > <stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>> >>> > >> > > <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com >>> >>>> >>> > >> > > > <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com >>> >>> >>> > >> > <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com> <mailto:stambau...@gmail.com >>> > <mailto:stambau...@gmail.com>> >>> > >> <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com> >>> > <mailto:stambau...@gmail.com <mailto:stambau...@gmail.com>>>>>> >>> wrote: >>> > >> > > > >>> > >> > > > When was the code that did not build >>> on msvc >>> > >> > introduced? If >>> > >> > > was early >>> > >> > > > then it might make sense to squash >>> > everything. >>> > >> > Otherwise, it >>> > >> > > may be >>> > >> > > > worthwhile squashing from the commit >>> > where the >>> > >> build >>> > >> > error was >>> > >> > > > introduced to and including the commit >>> where >>> > >> the build >>> > >> > error >>> > >> > > was fixed. >>> > >> > > > I don't have a preference one way or >>> the >>> > >> other. I'm >>> > >> > open to >>> > >> > > > suggestion. >>> > >> > > > >>> > >> > > > On 3/31/19 11:14 AM, Jon Evans wrote: >>> > >> > > > > Seth, I split up the initial rebased >>> > branch >>> > >> to make >>> > >> > review >>> > >> > > a bit >>> > >> > > > > easier. I could squash everything >>> > into one >>> > >> huge >>> > >> > commit if >>> > >> > > you'd >>> > >> > > > prefer. >>> > >> > > > > >>> > >> > > > > On Sun, Mar 31, 2019 at 9:56 AM Seth >>> > Hillbrand >>> > >> > > <s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>> >>> > >> > <mailto:s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>>> >>> > >> > > > <mailto:s...@hillbrand.org >>> > <mailto:s...@hillbrand.org> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>> >>> > >> > <mailto:s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>>>> >>> > >> > > > > <mailto:s...@hillbrand.org >>> > <mailto:s...@hillbrand.org> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> > <mailto:s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> > <mailto:s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>>> >>> > >> > > <mailto:s...@hillbrand.org >>> > <mailto:s...@hillbrand.org> <mailto:s...@hillbrand.org >>> > <mailto:s...@hillbrand.org>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>> >>> > >> > <mailto:s...@hillbrand.org <mailto: >>> s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>> >>> > >> <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org> >>> > <mailto:s...@hillbrand.org <mailto:s...@hillbrand.org>>>>>>> >>> wrote: >>> > >> > > > > >>> > >> > > > > Am 2019-03-30 17:33, schrieb >>> Simon >>> > >> Richter: >>> > >> > > > > > Hi Wayne, >>> > >> > > > > > >>> > >> > > > > > On 30.03.19 21:30, Wayne >>> Stambaugh >>> > >> wrote: >>> > >> > > > > > >>> > >> > > > > >> Is this the last of it? If >>> so, >>> > I will >>> > >> attempt to >>> > >> > > get this >>> > >> > > > merged >>> > >> > > > > >> tomorrow. >>> > >> > > > > > >>> > >> > > > > > Compiles fine on msys2 and >>> msvc. >>> > Not all >>> > >> > intermediate >>> > >> > > > commits compile, >>> > >> > > > > > but I'm not sure anyone does >>> > git-bisect >>> > >> anyway. >>> > >> > > > > >>> > >> > > > > I use git bisect frequently. >>> > Please do >>> > >> not push >>> > >> > > commits that >>> > >> > > > do not >>> > >> > > > > compile. This has been done >>> > previously >>> > >> and it added >>> > >> > > hours to >>> > >> > > > fixing a >>> > >> > > > > single bug in 5.0.1. >>> > >> > > > > >>> > >> > > > > -S >>> > >> > > > > >>> > >> > > > > >>> > >> _______________________________________________ >>> > >> > > > > Mailing list: >>> > >> > https://launchpad.net/~kicad-developers >>> > >> > > > > Post to : >>> > >> > kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>> >>> > >> > > > >>> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>>> >>> > >> > > > > >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>> >>> > >> > > > >>> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>>>> >>> > >> > > > > Unsubscribe : >>> > >> > https://launchpad.net/~kicad-developers >>> > >> > > > > More help : >>> > >> https://help.launchpad.net/ListHelp >>> > >> > > > > >>> > >> > > > > >>> > >> > > > > >>> > >> _______________________________________________ >>> > >> > > > > Mailing list: >>> > >> https://launchpad.net/~kicad-developers >>> > >> > > > > Post to : >>> > >> kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>> >>> > >> > > > >>> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>>> >>> > >> > > > > Unsubscribe : >>> > >> https://launchpad.net/~kicad-developers >>> > >> > > > > More help : >>> > >> https://help.launchpad.net/ListHelp >>> > >> > > > > >>> > >> > > > >>> > >> > > > >>> > _______________________________________________ >>> > >> > > > Mailing list: >>> > >> https://launchpad.net/~kicad-developers >>> > >> > > > Post to : >>> > >> kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>> >>> > >> > > > >>> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>> >>> > >> > > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>> >>> > >> > <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net> >>> > >> <mailto:kicad-developers@lists.launchpad.net >>> > <mailto:kicad-developers@lists.launchpad.net>>>>> >>> > >> > > > Unsubscribe : >>> > >> https://launchpad.net/~kicad-developers >>> > >> > > > More help : >>> > >> https://help.launchpad.net/ListHelp >>> > >> > > > >>> > >> > > >>> > >> > >>> > >> >>> > >>> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
