Hi JP,

Your menu fix for LINUX does work for OSX as well.  The problem is that because 
it didn’t understand the hotkey *before* your fix it ends up writing 0 
(“<unassigned>”) into the hotkeys config, so you have to have your fix *and* 
you have to reset your hotkeys to default.

Is there any way around that second part, or should we just live with it?

Cheers,
Jeff.




> On 13 Aug 2018, at 07:40, jp charras <[email protected]> wrote:
> 
> Le 12/08/2018 à 22:55, Jeff Young a écrit :
>> No change.  (Still works, still missing from menu.)
>> 
>> I can look into it later, if you like….
>> 
>> Cheers,
>> Jeff.
> 
> Please do.
> 
> Thanks.
> 
>> 
>> 
>>> On 12 Aug 2018, at 14:28, jp charras <[email protected]> wrote:
>>> 
>>> Le 12/08/2018 à 11:42, Jeff Young a écrit :
>>>> Alt-BkSp works on OSX (performs a Leave Sheet), but does not show up in
>>>> the menu:
>>>> 
>>>> 
>>>> It does show up in the Show Hotkeys dialog:
>>>> 
>>> 
>>> Hi Jeff,
>>> Could you have a look into common/hotkeys_basic.cpp, and in the 2 lines:
>>> 263 and 324, modify
>>> #ifdef  __LINUX__
>>> to enable it also on OSX, and see if  Alt-BkSp still works and is shown
>>> in menus.
>>> 
>>> Thanks.
>>> 
>>>> 
>>>> 
>>>>> On 9 Aug 2018, at 22:05, Jeff Young <[email protected]
>>>>> <mailto:[email protected]>> wrote:
>>>>> 
>>>>> I hope to have my tree back in working order tomorrow and could do
>>>>> this then….
>>>>> 
>>>>> Cheers,
>>>>> Jeff.
>>>>> 
>>>>> 
>>>>>> On 9 Aug 2018, at 20:36, Wayne Stambaugh <[email protected]
>>>>>> <mailto:[email protected]>> wrote:
>>>>>> 
>>>>>> On 8/9/2018 1:11 PM, jp charras wrote:
>>>>>>> Le 09/08/2018 à 19:02, Wayne Stambaugh a écrit :
>>>>>>>> On 8/9/2018 12:06 PM, jp charras wrote:
>>>>>>>>> Eeschema uses accelerator key BkSp (exactly Alt+BkSp) in view menu
>>>>>>>>> (View/Leave Sheet).
>>>>>>>>> 
>>>>>>>>> This accelerator works fine on Windows, and generates a warning on
>>>>>>>>> Linux
>>>>>>>>> (and is not shown in menu)
>>>>>>>>> 
>>>>>>>>> Reason:
>>>>>>>>> On Linux (GTK?) the accelerator key BkSp, when used in menus must be
>>>>>>>>> coded as "\t\b" and not "\tBkSp" (and the Alt+BkSp accelerator is
>>>>>>>>> \tAlt+\b)
>>>>>>>>> (\b is the ASCII code of Back Space key).
>>>>>>>>> However, On Windows, Alt+BkSp accelerator must be "\tAlt+BkSp".
>>>>>>>>> 
>>>>>>>>> I just fixed this minor issue in commit 78ab5c3f07
>>>>>>>>> Can someone test this commit on OSX and see if "\tAlt+BkSp" is
>>>>>>>>> working?
>>>>>>>>> Thanks.
>>>>>>>>> 
>>>>>>>> 
>>>>>>>> The gift that keeps on giving. ;)  Nice catch.  I wonder if the wx
>>>>>>>> folks
>>>>>>>> know this.  It would be nice if they fixed this one their end.
>>>>>>>> 
>>>>>>>> This is probably the cause of this bug report:
>>>>>>>> 
>>>>>>>> https://bugs.launchpad.net/kicad/+bug/1786113
>>>>>>>> 
>>>>>>>> The fix for this should also be cherry picked into the 5.0 branch.
>>>>>>> 
>>>>>>> Sure. I just need to know what happens on OSX.
>>>>>> 
>>>>>> Would one of our osx devs please check this for JP?
>>>>>> 
>>>>>> Thanks,
>>>>>> 
>>>>>> Wayne
>>>>>> 
>>>>>>> 
>>>>>>>> 
>>>>>>>> Cheers,
>>>>>>>> 
>>>>>>>> Wayne
>>> 
>>> -- 
>>> Jean-Pierre CHARRAS
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers 
> <https://launchpad.net/~kicad-developers>
> Post to     : [email protected] 
> <mailto:[email protected]>
> Unsubscribe : https://launchpad.net/~kicad-developers 
> <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp 
> <https://help.launchpad.net/ListHelp>
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to