Hey Jeff, I agree with these changes so as soon as Michael posts the revised patches, we can get them reviewed and I can merge them. Thanks for helping out with the patch review. I appreciate the help.
Cheers, Wayne On 2/16/2018 10:47 AM, Jeff Young wrote: > Hi Wayne, > > With these changes: > > “Footprint Library Wizard” and “Footprint Library Table” are > environmental settings so they belong under Preferences, not Setup. > That (and moving “User Defined Grid…”) should make it short enough > not to need the nested menu for Dimensions. > > I still feel strongly that “User Defined Grid…” belongs in the View > menu under “Show Grid” (and should be renamed “Grid Settings…”). > > Same for “Interactive Routing…” moving to the Route menu (and > perhaps becoming “Router Settings…”). Context (putting things that > are used together near each other) is more important than taxonomy > (arranging by logical grouping). > > For a drop-down menu, the first item is the hardest to select while > the second is the easiest. So for Inspect I’d suggest: > > Inspect > List Nets > Measure > —————————— > Design Rules Checker > > > I’m ready to go with it. I haven’t heard back from Michael yet, and I > don’t know what his turn-around time is. He’s been pretty responsive > so far, though. > > I could also make the changes, but I don’t want to step on his stuff…. > > Cheers, > Jeff. > > > >> On 16 Feb 2018, at 15:38, Wayne Stambaugh <[email protected] >> <mailto:[email protected]>> wrote: >> >> Gentlemen, >> >> Where do we stand on this? I would like to get this into rc1 if >> possible just to reduce long term maintenance issues. Once I branch >> version 5, all patches have to be merged from the development branch to >> the version 5 branch so it makes more work for me. >> >> Thanks, >> >> Wayne >> >> On 2/15/2018 3:42 PM, Michael Kavanagh wrote: >>> Thanks for that Orson, and sorry for causing so much confusion everyone. >>> Lesson learnt. Also thanks Jeff for helping with the dialog change. >>> >>> I'll pause for feedback and we can address the rest of the patches one >>> by one. For context here is what I suggest: >>> >>> * File: as per 0003-Fix-up-file-menu-and-hotkeys.patch >>> * View: see 0006-Add-missing-items-to-view-menu-and-improve.patch >>> * Setup: collect project/pcb specific settings into this menu >>> o Layers Setup... >>> o Design Rules... >>> o ------------------- >>> o Footprint Library Wizard >>> o Footprint Library Table >>> o ------------------- >>> o Dimensions >>> + User Defined Grid... >>> + Text and Drawings... >>> + Default Pad Properties... >>> + Pads to Mask Clearance... >>> + Differential Pairs... >>> * Place: as per 0005-Add-missing-tools-to-menubar.patch >>> o Footprint >>> o Via >>> o Zone >>> o Keepout Area >>> o Text >>> o Arc >>> o Circle >>> o Lines >>> o Polygons >>> o ------------ >>> o Dimension >>> o Layer Alignment Target >>> o ------------ >>> o Drill and Place Offset >>> o Grid Origin >>> * Route: leave as is >>> * Inspect: created in 0005-Add-missing-tools-to-menubar.patch >>> containing just Measure tool, add >>> o Design Rules Checker >>> o --------------- >>> o Measure >>> o List nets >>> * Tools >>> o >>> >>> * Preferences: reserved for suite/application settings eg >>> o Paths >>> o Display settings... >>> o Icons >>> o Languages >>> * Help >>> >>> Hopefully this provides some context/alleviates some confusion. With >>> what I suggest menu bar items follow a logical design flow: >>> Setup -> Place -> Route -> Inspect >>> Obviously, real life is never so perfect... >>> >>> Regards, >>> Michael >>> >>> >>> On 15 February 2018 at 19:42, Wayne Stambaugh <[email protected] >>> <mailto:[email protected]> >>> <mailto:[email protected]>> wrote: >>> >>> It appears in this case that they are being used as hotkeys rather >>> than >>> menu accelerators so no change is necessary. >>> >>> On 2/15/2018 11:40 AM, Maciej Sumiński wrote: >>>> Hi Wayne, >>>> >>>> I am not sure if there is an issue, I think cut/copy/paste are genuine >>>> hotkeys and not just accelerators, unless you have something else in >>>> mind. In any case, I have committed patch 0002 as is it was sent here. >>>> >>>> Cheers, >>>> Orson >>>> >>>> On 02/15/2018 05:31 PM, Wayne Stambaugh wrote: >>>>> Orson, >>>>> >>>>> Did you fix the IS_ACCELERATOR issue in patch 0002 when calling >>>>> AddHotkeyName()? >>>>> >>>>> Wayne >>>>> >>>>> On 2/15/2018 11:00 AM, Maciej Sumiński wrote: >>>>>> To reduce the discussion scope, I have committed the obvious >>> improvements: >>>>>> 0001-Fix-spelling-error.patch >>>>>> 0002-Improve-edit-menu-and-use-common-hotkeys.patch >>>>>> 0004-Remove-duplicate-track-menu-item.patch >>>>>> >>>>>> To be discussed: >>>>>> 0003-Fix-up-file-menu-and-hotkeys.patch >>>>>> 0005-Add-missing-tools-to-menubar.patch >>>>>> 0006-Add-missing-items-to-view-menu-and-improve.patch >>>>>> 0007-Remove-duplicate-menu-item.patch >>>>>> >>>>>> 0005-Grid-dialog-changes-to-go-along-with-menu-changes.patch (Jeff) >>>>>> >>>>>> Cheers, >>>>>> Orson >>>>>> >>>>>> >>>>>> On 02/15/2018 02:46 PM, Michael Kavanagh wrote: >>>>>>> Was this what you meant? >>>>>>> >>>>>>> On 15 February 2018 at 11:15, Jeff Young <[email protected] >>>>>>> <mailto:[email protected]> >>> <mailto:[email protected]>> wrote: >>>>>>> >>>>>>>> Hi Michael, >>>>>>>> >>>>>>>> Only thing I found wrong was that you have Sketch & Wireframe >>> zones >>>>>>>> backwards: >>>>>>>> >>>>>>>> Wireframe == ID_TB_OPTIONS_SHOW_ZONES_DISABLE >>>>>>>> >>>>>>>> Sketch == ID_TB_OPTIONS_SHOW_ZONES_OUTLINES_ONLY >>>>>>>> >>>>>>>> >>>>>>>> On the opinion side, the Inspect menu is growing on me. So if >>> no one else >>>>>>>> has objections to it, then I’ll shut up. ;) >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Jeff. >>>>>>>> >>>>>>>> >>>>>>>> On 15 Feb 2018, at 01:00, Michael Kavanagh >>> <[email protected] <mailto:[email protected]> >>> <mailto:[email protected]>> >>>>>>>> wrote: >>>>>>>> >>>>>>>> Lets start with these for now. Patches address a spelling >>> error in the >>>>>>>> code, edit, file and view menus, removes duplicate items and >>> adds missing >>>>>>>> tools. >>>>>>>> >>>>>>>> Please let me know your comments. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Michael >>>>>>>> >>>>>>>> On 14 February 2018 at 21:55, Michael Kavanagh >>> <[email protected] <mailto:[email protected]> >>> <mailto:[email protected]>> >>>>>>>> wrote: >>>>>>>>> Okay thanks. Also I think I messed up even the simple first >>> patch (git >>>>>>>>> n00b over here). Please await an updated patch set. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> Michael >>>>>>>>> >>>>>>>>> On 14 February 2018 at 21:30, Wayne Stambaugh >>> <[email protected] <mailto:[email protected]> >>> <mailto:[email protected]>> >>>>>>>> wrote: >>>>>>>>>> Michael, >>>>>>>>>> >>>>>>>>>> For future reference, please try to avoid posting a large >>> patch set like >>>>>>>>>> this. I makes it difficult to comment on them without the >>> email thread >>>>>>>>>> quickly becoming difficult to follow. Also, please make an >>> announcement >>>>>>>>>> on the mailing when making substantial changes like this. >>> You could >>>>>>>>>> have gotten the feedback first which would have saved you >>> some work. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> >>>>>>>>>> Wayne >>>>>>>>>> >>>>>>>>>> On 2/13/2018 5:46 PM, Michael Kavanagh wrote: >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I tried to fix up the Pcbnew menu bar a bit so its more >>> "standards >>>>>>>>>>> complaint" with regards to UI and also include options >>> where there are >>>>>>>>>>> toolbar buttons but no menu bar item. >>>>>>>>>>> >>>>>>>>>>> Tried to keep commits small, hence number of patches. >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Michael >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>>>>> Post to : [email protected] >>>>>>>>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>>>> Post to : [email protected] >>>>>>>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>>>>> >>>>>>>> <0001-Fix-spelling-error.patch><0002-Improve-edit-menu- >>>>>>>> >>> and-use-common-hotkeys.patch><0003-Fix-up-file-menu-and-hotkeys.patch> >>>>>>>> >>> <0004-Remove-duplicate-track-menu-item.patch><0005-Add-missing-tools- >>>>>>>> >>> to-menubar.patch><0006-Add-missing-items-to-view-menu-and-improve.patch> >>>>>>>> <0007-Remove-duplicate-menu-item.patch>________________________ >>>>>>>> _______________________ >>>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>> Post to : [email protected] >>>>>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>> Post to : [email protected] >>>>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>> Post to : [email protected] >>>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>> Post to : [email protected] >>>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>> Post to : [email protected] >>>> <mailto:[email protected]> >>> <mailto:[email protected]> >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> Post to : [email protected] >>> <mailto:[email protected]> >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/~kicad-developers> >>> More help : https://help.launchpad.net/ListHelp >>> <https://help.launchpad.net/ListHelp> >>> >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> <mailto:[email protected]> >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> <mailto:[email protected]> >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
