2017-11-22 9:19 GMT+01:00 Maciej Sumiński <maciej.sumin...@cern.ch>:
> Hi Nick, > > On 11/22/2017 12:04 AM, Nick Østergaard wrote: > > Thank your for fixing. Seems to address the issue. Some minor things > about > > it. > > > > It seems that it adds about two lines of whitespace inside that box where > > the checkboxes are, even if I edit more libs. > > Do you mean *less* libraries? I can see some empty space if I modify > only one or two libraries. I do not consider this a show stopper though. > I mean more, but it does not matter. The space is static. > > > And I canot not select/deselect with the space key when I highlighted a > > row. But I guess you didn't intend to implement that. > > I can do that in awm, gnome and xfce. I did not want to boot Windows > just to see if it is possible, but I believe it should work there too. I > think this is normally supported by wxWidgets, I cannot tell why it does > not work on your machine. > Maybe the selection scope is different somehow. > > > Thank you, not it can be used at least. :) > > > > I also see that you didn't change the tree behaivour when searching. > > Actually, I did. Try this: > - expand a few nodes > - start filtering by entering a search query > (some nodes collapse, the search results are exposed) > - clear the search query > - note the initial nodes are expanded again > > Hmm, I didn't notice this. > The expanded nodes are restored only when you stop filtering. I think it > makes sense, as you probably want to focus on the search results rather > than the libraries you have expanded earlier. > Sounds good. > > What do you think? Should the nodes expanded before filtering stay > expanded when you search for a specific component? > No. When searching it should just expand the libs with subresults that match the query. But this didn't happen for me. I can retest when I get home. I didn't note the commit tested. > > Cheers, > Orson > > > 2017-11-21 23:49 GMT+01:00 Maciej Suminski <maciej.sumin...@cern.ch>: > > > >> I have just managed to fix the last issue (disappearing buttons in 'Save > >> Library' dialog) and pushed the code to the master branch. > >> > >> Thank you for testing and comments, I really appreciate it. Now let's > >> have a look at the abandoned patches on the mailing list and the bug > >> tracker.. > >> > >> Regards, > >> Orson > >> > >> On 11/14/2017 05:37 PM, Maciej Sumiński wrote: > >>> The long awaited refactor of the Symbol Library Editor is ready for > >> testing! > >>> > >>> Changes (yes, it will be included in the commit message): > >>> - Component Tree widget as a user-friendly part selector > >>> - Multiple editor contexts, allowing the user to easily switch between > >>> modified parts > >>> - Cut/Copy/Paste/Duplicate for whole components (also between > libraries) > >>> - Reverting unsaved modifications per part or library > >>> - 'Browse' button for Symbol Library Table dialog to add files > >>> - Redone menu and toolbar > >>> - Improved icons to make the user interface more consistent > >>> > >>> I look forward to your feedback. I would like to merge the branch this > >>> week, which would most likely indicate the v5 feature freeze start > >> (yay!). > >>> > >>> I have also started to work on copy/paste for individual part items, > but > >>> I cannot fully wrap my head around eeschema code. If such feature is > >>> desired and you are willing to help, I can share my desperate trial > >>> patch. I will try to implement it before the branch is merged, > otherwise > >>> copy/paste will be postponed to v6. > >>> > >>> Regards, > >>> Orson > >>> > >>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/libedit > >>> > >>> > >>> > >>> _______________________________________________ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >>> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp > >> > > > > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
