Orson, Literally 10 seconds after submitting the patch I realised that .Lower() was the superior solution :)
Thanks, Oliver On Mon, Nov 6, 2017 at 11:17 PM, Maciej Sumiński <[email protected]> wrote: > Hi Oliver, > > If I may suggest one thing, then I would turn: > > + if( ext == "wrl" || ext == "WRL" || ext == "Wrl" ) > + return FMT_WRL; > > into: > > + if( ext.Lower() == "wrl" ) > + return FMT_WRL; > > Apart from that, the patch seems fine just by reading the contents. No > need to send another patch, I think it can fixed by the committer. I > have not merged it only because I have not had a chance to build and > test it *yet*. Thank you very much for fixing another bug! > > Cheers, > Orson > > On 11/04/2017 01:47 PM, Oliver Walters wrote: > > The attached patch implements the feature suggested here : > > https://bugs.launchpad.net/kicad/+bug/1710796 > > > > Problem: > > > > .wrl files are specified as default but these don't export to MCAD. > > > > Solution: > > > > On STEP export, wrl files are replaced with their step counterparts (if > > such models exist). > > > > This is essentially what Maurice's famous StepUP tool does. > > > > Turns out it was a pretty simple fix :) > > > > Regards, > > Oliver > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
