On 11/03/2017 01:38 PM, Carsten Schoenert wrote: > Hello Marvin, > > Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: >> Just a set of small code cleanups to fix a bunch of warnings >> and remove dead code. >> Other than that the 'build:' commits avoid/remove/fix the >> installation of certain files: >> - it doesn't make much sense to install the INSTALL.txt >> - *.bat scripts shouldn't be installed on UNIX systems >> - use CMAKE_INSTALL_* consistently to install files in the >> correct places > wouldn't it make more sense to write the specific reason for the commits > *into* the specific commit? > This email with your explanation why you have done all that work will go > down under in the typical noise of the mailing list and nobody but you > will later know why the single commit was made.
I think the e-mail subject contains the first line of commit message that explains the changes and most likely is handled correctly by git-am. Personally, I prefer patches sent as attachments as I do not use a client that is compatible with git-am. I also wonder whether git-am chokes on the lines add by launchpad in every message. Apart from that, I think the proposed changes are reasonable and could be merged. Regards, Orson
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
