On 2/7/2017 8:29 AM, Chris Pavlina wrote: > Commit 43cb4560bfcf0624e9707c4c512cc3ccce385ce9 > > Rewrite code for PANEL_PREV_3D because the way events were previously managed > are not compatible with a good mouse event management. > To avoid a lot of tedious code, wxFormbuilder is used to create the > PANEL_PREV_3D_BASE class. > > ...didn't we agree we should reduce the use of wxformbuilder in new > code? There are plenty of ways the tedious code could be avoided without > using it - for instance, that panel is very repetitive, a function could > be created to populate a section...
After the next stable release, we should not be using wxFormbuilder for new code. Until then it's business as usual but adding more wxFormbuilder stuff probably doesn't make much sense because eventually it will get removed. I just don't see a way forward with wxFormbuilder unless someone starts actively developing it. Even if they did, I'm still not a big fan. It's fine to use as a prototyping tool if you need it to layout dialogs. You could just as easily use wxFormbuilder to create the source files, strip out the comments, reformat them with uncrustify, and just commit the source files without deriving from a base dialog object as we currently do. Generally speaking, we don't make massive changes to dialogs once they are designed so maintenance shouldn't be a huge issue. Cheers, Wayne _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
