On 1/31/2017 10:32 AM, John Beard wrote: > Hi, > > The attached patches add the "exchange footprints" command to the GAL edit > tool. > > This is 1 out of 3 parts of > https://bugs.launchpad.net/kicad/+bug/1541460. I'm not sure how to put > this as a commit comment exactly.
I changed the description of this bug report for just the exchange footprint command so you patch set should reference this bug report. I will file separate bug reports for the rotate and drag footprint commands. > > This is implemented as two segments: > > * Put the dialog/exchange FP code into pcbnew/dialogs directory (as a > header/implementation pair) where it can be reached by bother > pcbframe.cpp and GAL tools. This also makes it easier to remove legacy > calling code in future. No change is made to the functionality of the > dialog. > * Add the tool to the GAL, calling the dialog as needed. > > The third patch is optional, but tidies up a copy-pasted selection > routine into a named function and adds a little commentary to a couple > of related existing functions. > > Cheers, > > John > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
