On Fri, Jan 27, 2017 at 11:32:06PM -0500, Wayne Stambaugh wrote: > On 1/27/2017 7:40 PM, Chris Pavlina wrote: > > On Fri, Jan 27, 2017 at 07:28:09PM -0500, Wayne Stambaugh wrote: > >> On 1/27/2017 6:02 PM, Chris Pavlina wrote: > >>> On Fri, Jan 27, 2017 at 05:21:42PM -0500, Wayne Stambaugh wrote: > >>>> I finally got the new schematic I/O plugin fully functional for the > >>>> current schematic and symbol library file formats. When you have some > >>>> time, please test this to see if I've missed anything. I've pushed it > >>>> to my repo on launchpad here: > >>>> > >>>> https://code.launchpad.net/~stambaughw/kicad/+git/kicad-dev/+ref/use-symbol-library-table > >>>> > >>>> There is a noticeable performance hit on start up when loading a > >>>> schematic. > >>> > >>> Holy crap, there is a performance hit of _over a minute_ loading the > >>> project I'm working on! > >> > >> Debug or release build? I saw significantly longer load times on debug > >> builds although release builds were no speed demon either. I'll step > >> through it again tomorrow just to see if I missed where the cache may be > >> getting reloaded. > > > > Release build. Not a huge project either, seven pages and 354 > > components... > > I fixed the issue and pushed to my dev branch so it should be much more > usable now.
Much better. It's still a bit slow relative to the old code but only "several seconds" slow now. > > > > >> > >>> > >>> I'm testing this though. > >>> > >>>> I'm not sure why this is happening but I believe it has to > >>>> do with the cache validity test being called on every symbol search. I > >>>> verified that the cache isn't being reloaded but I'm a bit surprised > >>>> that there was as much of a performance hit. If you happen to notice > >>>> something I missed please let me know. I am primarily concern with the > >>>> accuracy and stability of the library file I/O at this point. I tested > >>>> everything I could think of against the current code and always got the > >>>> same file results but there may have been some corner cases that I > >>>> missed. The performance hit will be temporary. Once the symbol library > >>>> table support is implemented, the symbol search through the entire > >>>> library list will go away. Either the symbol is in the library > >>>> specified or it's not. I will probably introduce lazy loading as well > >>>> once the symbol library table is implemented as only libraries that > >>>> contain symbols in the schematic will need to be loaded when the > >>>> schematic is opened. Many thanks in advance for the help. > >>>> > >>>> Cheers, > >>>> > >>>> Wayne > >>>> > >>>> _______________________________________________ > >>>> Mailing list: https://launchpad.net/~kicad-developers > >>>> Post to : kicad-developers@lists.launchpad.net > >>>> Unsubscribe : https://launchpad.net/~kicad-developers > >>>> More help : https://help.launchpad.net/ListHelp > >> > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
