Should it be enabled in the windows nightlies now or should we wait a bit?

2017-01-23 14:13 GMT+01:00 jp charras <jp.char...@wanadoo.fr>:
> Le 18/01/2017 à 18:00, Jean-Samuel Reynaud a écrit :
>> Just to know if this patch is now acceptable ? Did you plan to commit it ?
>>
>> Thanks,
>> Le 17/01/2017 à 19:46, Jean-Samuel Reynaud a écrit :
>>>> yes i was trying to subtly imply that :)
>>> ok, find attached the patch with the about box updated ;)
>>>
>>> Regards,
>>>
>
> I committed the patch ( with fixes, see comments) in rev:
> 2b5769c0a8568e421c2152177a8f1c27d9bf9cb5
>
> Jean-Samuel, thanks, and please carefully test this rev, to be sure I did not 
> break anything.
>
> The action plugin feature must be currently seen as an experimental feature, 
> for developers, because
> it can easily break a board.
> It is enabled if the option -DKICAD_SCRIPTING_ACTION_MENU=ON is added to the 
> cmake command line.
>
> I am thinking this feature need to be tested, and enhancements added 
> (especially if a script deletes
> a board item), and this is the reason I see it as currently experimental.
>
> However, now it exists, it can be tested.
>
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to