> - Duplicating a group should create a new group (I'm not sure it works > this way for the moment).
Currently duplication just copies the group, but yes, I can change so that it appends -{num} from 1 and upwards when copying. Here I also guess that ideally they would be a subgroup of a nested group after that. {groupname}-copies for example > You can for instance > define a group as a set of unique timestamps of the items which belong > to it. This would also simplify the file format by not polluting the > board entities with group information, e.g. I am not sure I like this, the format pollution you mention is actually something I want, It makes the file format easy to scan with a text editor, which is something I have had to do a few times when using Kicad. But ofcourse I could probably change that if it is deemed neccesary. How does timestamps work? Are they unique always or are they an indication at what time something is added/edited? > - Add Group/Ungroup commands to the Edit menu. Not sure I follow, do you mean the preferences menu? The one you get with the shortcut E? > - if you click on a group member, the selection tool IMHO should select > the group the member belongs to. An alternate mode (e.g. Shift+click) > could be used to pick single elements from a group. This is the typical > behaviour of all programs I know that support grouping (from > Corel/Inkscape to Altium). Hmm, yes, that seems more natural. > - Add a shortcut to group/ungroup (e.g. Ctrl+G/Ctrl+U). > - Add a 'merge groups' option which squashes several groups into a - > single one. Will look into it, although I see these as additions to a feature not yet On 01/19/2017 02:30 PM, Tomasz Wlostowski wrote: > On 19.01.2017 12:18, Kristoffer Ödmark wrote: >> Hey! >> >> Did you have a look at the group selection patch and have any comments? :) > > Hi, > > Yes, but I didn't have much time. My quick observations: > - if you click on a group member, the selection tool IMHO should select > the group the member belongs to. An alternate mode (e.g. Shift+click) > could be used to pick single elements from a group. This is the typical > behaviour of all programs I know that support grouping (from > Corel/Inkscape to Altium). > - Add a shortcut to group/ungroup (e.g. Ctrl+G/Ctrl+U). > - Add Group/Ungroup commands to the Edit menu. > - Add a 'merge groups' option which squashes several groups into a - > single one. > - Duplicating a group should create a new group (I'm not sure it works > this way for the moment). > - Add a possibility to have recursive grouping. This probably means a > bit of changes in the file format and code model. You can for instance > define a group as a set of unique timestamps of the items which belong > to it. This would also simplify the file format by not polluting the > board entities with group information, e.g. > > (track (timestamp A) ... ) > (track (timestamp B) ... ) > (track (timestamp C) ... ) > (track (timestamp D) ... ) > > // all grouping info stored in a separate section of the file which > translates to a separate object within the BOARD. > (groups > ( group (name small1) (timestamp X) ids ( A B ) ) > ( group (name small2) (timestamp Y) ids ( C D ) ) > ( group (name twogroupstogether) (timestamp Z) ids ( X Y ) ) > ) > > If you had time, you could also extend the 'append board' feature to: > - Let the user append a board as a new group. > - Optionally, rename the nets so that they are in a 'private' namespace > in each appended board. > This would be a *big* help for panelization which currently is quite > cumbersome in Kicad. > > Many thanks for your efforts, > Tom > > > >> - Kristoffer >> >> >> On 2017-01-12 12:55, Tomasz Wlostowski wrote: >>> I like it. Give me a few days to review it and I hope it will get >>> merged. You'll also have to make the groups persistent (save to file). >>> Recursive grouping (group of groups) would be also an advantage. >>> >>> >>> Cheers, >>> Tom >>> >>> Sent from my Samsung Galaxy smartphone. >>> >>> >>> -------- Original message -------- >>> From: Kristoffer Ödmark <kristofferodmar...@gmail.com> >>> Date: 12/01/2017 12:41 (GMT+01:00) >>> To: kicad-developers@lists.launchpad.net >>> Subject: Re: [Kicad-developers] Group selection idea >>> >>> Hey again, What would be the chances of seing this getting into the >>> master branches on launchpad, what would I have to add/change to get it >>> there? >>> >>> - Kristoffer >>> >>> On 2017-01-11 21:59, Kristoffer Ödmark wrote: >>>> Attaching Patch! >>>> >>>> ( Thanks Chris! ) >>>> >>>> On 2017-01-11 20:51, Kristoffer Ödmark wrote: >>>>> Hello! >>>>> >>>>> I hacked together a group selection concept looking like this: >>>>> https://youtu.be/eJp-aJ8i0H4 >>>>> >>>>> It can assign BOARD_ITEM to a specific group for easier selection and >>>>> group manipulation. I am open to suggestions on changes, this is surely >>>>> not an optimal implementation. >>>>> >>>>> Useful when you may want to keep the relative position of something on >>>>> the board like maybe a RF layout etc. >>>>> >>>>> It cannot currently save the group assignments between sessions, since >>>>> that would require some changes to the file format. That would need >>> some >>>>> agreement that this is indeed wanted. >>>>> >>>>> it also doesnt work on zones right now. >>>>> >>>>> ps: I do not now the best way to attach a patch file. >>>>> I added my feature >>>>> commit >>>>> git pull >>>>> fix conflict >>>>> commit >>>>> >>>>> Anyone have any steps on how to get one patch file for this, now I got >>>>> one patch file, and a merge. >>>>> >>>>> - Kristoffer >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> <https://launchpad.net/%7Ekicad-developers> >>> More help : https://help.launchpad.net/ListHelp >> > -- -Kristoffer _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp