Sorry sometimes I respond with the wrong email address... On Jun 11, 2015 8:33 PM, "Adam Wolf" <adamww...@gmail.com> wrote:
> There is also other Mac packaging stuff from a few years ago that can be > removed safely. If no one objects. I can prepare a patch for those as well. > > Adam Wolf > On Jun 11, 2015 8:08 PM, "Bernhard Stegmaier" <stegma...@sw-systems.de> > wrote: > >> osx_fixbundles.sh was the script that did the library bundling before I >> changed it to using builtin CMake functions for it. >> Maybe it is still referenced here and there in some old CMake code, but >> IMHO it can just be deleted with every reference to it. >> >> >> Regards, >> Bernhard >> >> >> On 11 Jun 2015, at 21:24, Garth Corral <gcor...@abode.com> wrote: >> >> I think that can go. Though it looks like there’s some code in >> osx_fixbundles.sh that ostensibly migrates kiface modules inside the >> bundle, that code looks out of date and inert. Perhaps Bernhard has some >> insight into what that’s supposed to be doing. >> >> There are a couple of other references to cvpcb.app in CMakeList files. >> I’ve attached a patch with this as well as those. There’s also some >> references in the packaging directory, but I suspect that isn’t being used >> at the moment so I’ve left it alone. >> >> I used the same approach that you did for the other cvpcb stuff in >> CMakeLists, but I presume those blocks will be removed entirely in the near >> future. >> >> >> Garth >> >> <nix_cvpcb.patch> >> >> On Jun 11, 2015, at 10:46 AM, Wayne Stambaugh <stambau...@gmail.com> >> wrote: >> >> Thanks Adam. As soon as you let me know, I will commit the changes. >> >> On 6/11/2015 1:48 PM, Adam Wolf wrote: >> >> I bet it can be. >> >> I will put checking that on the top of my KiCad list. >> >> Adam Wolf >> >> On Thu, Jun 11, 2015 at 12:42 PM, Wayne Stambaugh <stambau...@gmail.com >> <mailto:stambau...@gmail.com <stambau...@gmail.com>>> wrote: >> >> Adam, >> >> There is also this line (521) in CMakeList.txt: >> >> add_custom_target( osx_fix_bundles ALL DEPENDS >> cvpcb eeschema gerbview kicad pcbnew bitmap2component >> pcb_calculator pl_editor) >> >> >> I'm guessing cvpcb can be removed from the list. >> >> Wayne >> >> On 6/11/2015 11:44 AM, Adam Wolf wrote: >> >> Builds resumed on the build cluster. >> >> I need to understand the bundling a bit more--for instance, should we >> still be adding cvpcb.app to search lists in gestfich.cpp? >> >> Adam Wolf >> >> On Thu, Jun 11, 2015 at 7:15 AM, Wayne Stambaugh <stambau...@gmail.com < >> mailto:stambau...@gmail.com <stambau...@gmail.com>> >> <mailto:stambau...@gmail.com <stambau...@gmail.com> < >> mailto:stambau...@gmail.com <stambau...@gmail.com>>>> wrote: >> >> Thanks Garth. I committed your patch in the product branch r5731. >> Hopefully this will get the OSX users back up and running. >> >> Cheers, >> >> Wayne >> >> On 6/11/2015 4:16 AM, Garth Corral wrote: >> >> >> Looks like the OS X install is trying to copy the nonexistant cvpcb.app >> into the main bundle, killing the build. >> >> >> Patch attached >> >> >> >> >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net>> >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net> >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net>>> >> >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net>> >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net> >> >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net>>> >> >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> <mailto:kicad-developers@lists.launchpad.net >> <kicad-developers@lists.launchpad.net>> >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
