> On Apr 25, 2015, at 9:41 PM, Blair Bonnett <blair.bonn...@gmail.com> wrote: > > Hi all, > > I've been going through the code removing redundant conditionally compiled > blocks for versions of wxWidgets before 3.0 as per the 'Conversion to > wxWidgets 3.0' section of the roadmap [1]. For the most part this is > straightforward as the wxCHECK_VERSION macro is used which makes the intent > clear. However I have run into a couple of cases using the major and minor > constants in a strange way which I want to run past the list first in case my > assumptions are wrong. > > First, on common/draw_panel.cpp line 933 [2]: > > #if wxMAJOR_VERSION >= 2 && wxMINOR_VERSION >= 9 > int axis = event.GetWheelAxis(); > #else > const int axis = 0; > #endif > > As it stands, this will be true for wxWidgets 2.9, 3.9, 3.10, 4.9 etc. I'm > pretty sure this is supposed to be checking for wxWidgets >= 2.9 since, as > far as I can tell, that was when GetWheelAxis() was added. > Yes, I noticed this when I was working on the trackpad stuff. I replaced it with #if wxCHECK_VERSION(2, 9, 0) on my branch since it was before the conversion, but as far as I can tell your assumptions are not wrong.
Garth
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
