Hi Mauricio,

Thank you very much for reviewing this. I've updated the PPA [1] with
the highlighted changes. I hope they are correct, but please let me know
if I missed anything.

[1] https://launchpad.net/~jasimioni/+archive/ubuntu/dmidecode-lp2081611

Here are the tests for Jammy and Noble, comparing the output in a system
without the new features. They are unchanged, as expected:

Jammy
-----

# Before:

ubuntu@dmidecode-jammy:~$ dpkg -l | grep -i dmidecode
ii  dmidecode                       3.3-3ubuntu0.1                          
amd64        SMBIOS/DMI table decoder
ubuntu@dmidecode-jammy:~$ sudo dmidecode > old.txt 2>&1
ubuntu@dmidecode-jammy:~$ sudo dmidecode --dump-bin old.bin
# dmidecode 3.3
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.
13 structures occupying 644 bytes.
Table at 0xBF921000.

# Writing 644 bytes to old.bin.
# Writing 31 bytes to old.bin.

# After

ubuntu@dmidecode-jammy:~$ dpkg -l | grep -i dmidecode
ii  dmidecode                       3.3-3ubuntu0.2                          
amd64        SMBIOS/DMI table decoder
ubuntu@dmidecode-jammy:~$ sudo dmidecode > new.txt 2>&1
ubuntu@dmidecode-jammy:~$ sudo dmidecode --dump-bin new.bin
# dmidecode 3.3
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.
13 structures occupying 644 bytes.
Table at 0xBF921000.

# Writing 644 bytes to new.bin.
# Writing 31 bytes to new.bin.

ubuntu@dmidecode-jammy:~$ ls -l
total 24
-rw-r--r-- 1 root   root    676 Oct 16 14:16 new.bin
-rw-rw-r-- 1 ubuntu ubuntu 4828 Oct 16 14:16 new.txt
-rw-r--r-- 1 root   root    676 Oct 16 14:15 old.bin
-rw-rw-r-- 1 ubuntu ubuntu 4828 Oct 16 14:14 old.txt
ubuntu@dmidecode-jammy:~$ cmp old.txt new.txt; echo $?
0
ubuntu@dmidecode-jammy:~$ cmp old.bin new.bin; echo $?
0
ubuntu@dmidecode-jammy:~$ strings $(which dmidecode) | grep 'Thread Enabled'
Thread Enabled


Noble
-----

# Before

ubuntu@dmidecode-noble:~$ dpkg -l | grep -i dmidecode
ii  dmidecode                       3.5-3build1                             
amd64        SMBIOS/DMI table decoder
ubuntu@dmidecode-noble:~$ sudo dmidecode > old.txt 2>&1
ubuntu@dmidecode-noble:~$ sudo dmidecode --dump-bin old.bin
# dmidecode 3.5
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.
13 structures occupying 644 bytes.
Table at 0xBF921000.

# Writing 31 bytes to old.bin.
# Writing 644 bytes to old.bin.

# After

ubuntu@dmidecode-noble:~$ dpkg -l | grep -i dmidecode
ii  dmidecode                       3.5-3ubuntu0.1                          
amd64        SMBIOS/DMI table decoder
ubuntu@dmidecode-noble:~$ sudo dmidecode > new.txt 2>&1
ubuntu@dmidecode-noble:~$ sudo dmidecode --dump-bin new.bin
# dmidecode 3.5
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.
13 structures occupying 644 bytes.
Table at 0xBF921000.

# Writing 31 bytes to new.bin.
# Writing 644 bytes to new.bin.

ubuntu@dmidecode-noble:~$ ls -l
total 24
-rw-r--r-- 1 root   root    676 Oct 16 13:49 new.bin
-rw-rw-r-- 1 ubuntu ubuntu 4828 Oct 16 13:49 new.txt
-rw-r--r-- 1 root   root    676 Oct 16 13:48 old.bin
-rw-rw-r-- 1 ubuntu ubuntu 4828 Oct 16 13:48 old.txt
ubuntu@dmidecode-noble:~$ cmp old.txt new.txt; echo $?
0
ubuntu@dmidecode-noble:~$ cmp old.bin new.bin; echo $?
0

ubuntu@dmidecode-noble:~$ strings $(which dmidecode) | grep 'Thread Enabled'
Thread Enabled

I'll ask Jamie to re-run the tests in a newer system and share them
here.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to dmidecode in Ubuntu.
https://bugs.launchpad.net/bugs/2081611

Title:
  Add processor support from SMBIOS 3.6.0 in Jammy and Noble

Status in dmidecode package in Ubuntu:
  Fix Released
Status in dmidecode source package in Jammy:
  Incomplete
Status in dmidecode source package in Noble:
  Incomplete

Bug description:
  [Impact]

   * Add processor support from SMBIOS 3.6.0 in Jammy and Noble
     to enable new hardware in LTS release per SRU policy [1].

   * Backport of 1 relatively simple patch from dmidecode 3.6
     in Oracular to dmidecode 3.3 in Jammy and dmidecode 3.5 in Noble

  [Test Plan]

   * Check no regressions on current systems with SMBIOS < 3.6,
     i.e., no output changes in text and binary form.

      $ sudo dmidecode > old.txt 2>&1
      $ sudo dmidecode --dump-bin old.bin

      $ apt install dmidecode # modified package

      $ sudo dmidecode > new.txt 2>&1
      $ sudo dmidecode --dump-bin new.bin

      $ cmp old.txt new.txt; echo $?
      0

      $ cmp old.bin new.bin; echo $?
      0

   * Check for expected output on new systems with SMBIOS >= 3.6.

     $ diff old.txt new.txt

     1) Run "sudo dmidecode -t4"
     2) Observe that the "Thread Enabled" field is being reported

  [1] https://canonical-sru-docs.readthedocs-
  hosted.com/en/latest/reference/requirements/#other-safe-cases

  [Patch Details]

  
https://git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=ac65cf23af7cccecb4175d3c13460928e8e2f51d

  Commit ac65cf23af7cccecb4175d3c13460928e8e2f51d
  Author: Jean Delvare <jdelv...@suse.de>
  Date:   Fri May 26 17:41:51 2023 +0200

      dmidecode: Add processor support from SMBIOS 3.6.0

      SMBIOS 3.6.0 adds the following to the Processor Information
      structure (type 4):
      * 9 socket types
      * 1 processor family
      * 1 field (Thread Enabled)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dmidecode/+bug/2081611/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to