Testing for Mantic:
mantic-updates:
$ rmadison -a source zfs-linux -s mantic-updates
zfs-linux | 2.2.0-0ubuntu1~23.10 | mantic-updates | source
$ dpkg -s zfs-zed | grep Version:
Version: 2.2.0-0ubuntu1~23.10
$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
$ dpkg -L zfs-zed | xargs grep ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT
2>/dev/null | sort
/etc/zfs/zed.d/zed.rc:#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:# 2:
ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT disabled
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:#
ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT is set in zed.rc, and the disk gets
/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:if [
"${ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT}" != "1" ] ; then
test package:
$ dpkg-deb -x zfs-zed_2.2.0-0ubuntu1~23.10.1_amd64.deb deb
$ grep ZED_POWER_OFF_ENCLO deb/etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
- wrong name (no matches anymore):
$ find deb | xargs grep ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT
2>/dev/null
$
- right name (all matches fixed):
$ find deb | xargs grep ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT
2>/dev/null | sort
deb/etc/zfs/zed.d/zed.rc:#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:# 2:
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT disabled
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:#
ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT is set in zed.rc, and the disk gets
deb/usr/lib/zfs-linux/zed.d/statechange-slot_off.sh:if [
"${ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT}" != "1" ] ; then
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2046082
Title:
zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT
Status in zfs-linux package in Ubuntu:
Fix Released
Status in zfs-linux source package in Mantic:
Confirmed
Status in zfs-linux source package in Noble:
Fix Released
Bug description:
[Impact]
* There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.
* This could be fixed in Ubuntu before users start adopting it.
[Test Plan]
* Check whether /etc/zfs/zed.d/zed.rc ships the correct option.
* Actual:
$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1
* Expected:
$ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
#ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1
[Regression Potential]
* Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
(published to mantic-updates on 2023-12-08) _and_ enabled the
option (with typo) would have such functionality disabled.
[Other Info]
* This option (with typo) was introduced in commit d19304ffeec5
("zed: Add zedlet to power off slot when drive is faulted"),
and is present in:
- ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
- ZFS 2.1: zfs-2.1.13
* It affects Ubuntu Noble and Mantic, but not Lunar or older.
* Fixed upstream with commit 3c7650491b9a ("zed: fix typo in
variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
