Patch submitted for review: https://lists.ubuntu.com/archives/kernel- team/2023-June/140646.html
** Description changed: + SRU Justification + + [Impact] + If the daemon is started and the vmbus is not present it will just exit with an error: https://git.launchpad.net/~ubuntu- kernel/ubuntu/+source/linux/+git/mantic/tree/tools/hv/hv_kvp_daemon.c#n1424 Thus, it would make sense to add "ConditionPathExists=/dev/vmbus/hv_kvp" in linux-cloud-tools-common.hv-kvp-daemon.service to prevent systemd from starting the daemon if the device is not there. + + [Test Plan] + + Start an Azure cloud instance and check for /dev/vmbus/hv_kvp and that hv-kvp-daemon is running. + Start a non-Azure cloud instance and check that hv-kvp-daemon is not running. + + + [Regression potential] + + Its possible that kv-hvp-daemon is not started when it should be. ** Also affects: linux (Ubuntu Lunar) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Kinetic) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Mantic) Importance: Undecided Status: Incomplete ** Also affects: linux (Ubuntu Jammy) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Focal) Status: New => In Progress ** Changed in: linux (Ubuntu Focal) Assignee: (unassigned) => Tim Gardner (timg-tpi) ** Changed in: linux (Ubuntu Jammy) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Jammy) Status: New => In Progress ** Changed in: linux (Ubuntu Jammy) Assignee: (unassigned) => Tim Gardner (timg-tpi) ** Changed in: linux (Ubuntu Kinetic) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Kinetic) Status: New => In Progress ** Changed in: linux (Ubuntu Kinetic) Assignee: (unassigned) => Tim Gardner (timg-tpi) ** Changed in: linux (Ubuntu Lunar) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Lunar) Status: New => In Progress ** Changed in: linux (Ubuntu Lunar) Assignee: (unassigned) => Tim Gardner (timg-tpi) ** Changed in: linux (Ubuntu Mantic) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Mantic) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu Mantic) Assignee: (unassigned) => Tim Gardner (timg-tpi) ** Changed in: linux (Ubuntu Mantic) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2024900 Title: Disable hv-kvp-daemon if /dev/vmbus/hv_kvp is not present Status in linux package in Ubuntu: Fix Committed Status in linux source package in Focal: In Progress Status in linux source package in Jammy: In Progress Status in linux source package in Kinetic: In Progress Status in linux source package in Lunar: In Progress Status in linux source package in Mantic: Fix Committed Bug description: SRU Justification [Impact] If the daemon is started and the vmbus is not present it will just exit with an error: https://git.launchpad.net/~ubuntu- kernel/ubuntu/+source/linux/+git/mantic/tree/tools/hv/hv_kvp_daemon.c#n1424 Thus, it would make sense to add "ConditionPathExists=/dev/vmbus/hv_kvp" in linux-cloud-tools- common.hv-kvp-daemon.service to prevent systemd from starting the daemon if the device is not there. [Test Plan] Start an Azure cloud instance and check for /dev/vmbus/hv_kvp and that hv-kvp-daemon is running. Start a non-Azure cloud instance and check that hv-kvp-daemon is not running. [Regression potential] Its possible that kv-hvp-daemon is not started when it should be. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2024900/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
