Public bug reported:

fix race on port output

* Explain the bug(s)

there is a race condition on port output

* brief explanation of fixes

We found that upstream linux has the same issue and fix

commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8
Author: Felix Huettner <felix.huettner@mail.schwarz>
Date:   Wed Apr 5 07:53:41 2023 +0000

    net: openvswitch: fix race on port output

    assume the following setup on a single machine:
    1. An openvswitch instance with one bridge and default flows
    2. two network namespaces "server" and "client"
    3. two ovs interfaces "server" and "client" on the bridge
    4. for each ovs interface a veth pair with a matching name and 32 rx and
       tx queues
    5. move the ends of the veth pairs to the respective network namespaces
    6. assign ip addresses to each of the veth ends in the namespaces (needs
       to be the same subnet)
    7. start some http server on the server network namespace
    8. test if a client in the client namespace can reach the http server
...
    Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
    Co-developed-by: Luca Czesla <luca.czesla@mail.schwarz>
    Signed-off-by: Luca Czesla <luca.czesla@mail.schwarz>
    Signed-off-by: Felix Huettner <felix.huettner@mail.schwarz>
    Reviewed-by: Eric Dumazet <eduma...@google.com>
    Reviewed-by: Simon Horman <simon.hor...@corigine.com>
    Link: https://lore.kernel.org/r/ZC0pBXBAgh7c76CA@kernel-bug-kernel-bug
    Signed-off-by: Jakub Kicinski <k...@kernel.org>

* How to test
After configuring QoS on BF-3:
Disable all priorities
Set priorities [0, 0, 0, 0, 0, 0, 0, 0]
Remove all policies
Remove all traffic classes
Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, 
dscp=None)
Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, 
dscp=None)
Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS
Enable QOS on adapter SLOT 5 Port 1
Restart driver (detach VFs -> restart with devcon -> attach VFs)

BF-3 sometimes stops responding. need to run it multiple times!

** Affects: linux-bluefield (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/2020606

Title:
  net: openvswitch: fix race on port output

Status in linux-bluefield package in Ubuntu:
  New

Bug description:
  fix race on port output

  * Explain the bug(s)

  there is a race condition on port output

  * brief explanation of fixes

  We found that upstream linux has the same issue and fix

  commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8
  Author: Felix Huettner <felix.huettner@mail.schwarz>
  Date:   Wed Apr 5 07:53:41 2023 +0000

      net: openvswitch: fix race on port output

      assume the following setup on a single machine:
      1. An openvswitch instance with one bridge and default flows
      2. two network namespaces "server" and "client"
      3. two ovs interfaces "server" and "client" on the bridge
      4. for each ovs interface a veth pair with a matching name and 32 rx and
         tx queues
      5. move the ends of the veth pairs to the respective network namespaces
      6. assign ip addresses to each of the veth ends in the namespaces (needs
         to be the same subnet)
      7. start some http server on the server network namespace
      8. test if a client in the client namespace can reach the http server
  ...
      Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
      Co-developed-by: Luca Czesla <luca.czesla@mail.schwarz>
      Signed-off-by: Luca Czesla <luca.czesla@mail.schwarz>
      Signed-off-by: Felix Huettner <felix.huettner@mail.schwarz>
      Reviewed-by: Eric Dumazet <eduma...@google.com>
      Reviewed-by: Simon Horman <simon.hor...@corigine.com>
      Link: https://lore.kernel.org/r/ZC0pBXBAgh7c76CA@kernel-bug-kernel-bug
      Signed-off-by: Jakub Kicinski <k...@kernel.org>

  * How to test
  After configuring QoS on BF-3:
  Disable all priorities
  Set priorities [0, 0, 0, 0, 0, 0, 0, 0]
  Remove all policies
  Remove all traffic classes
  Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, 
port=20000, dscp=None)
  Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, 
port=26000, dscp=None)
  Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS
  Enable QOS on adapter SLOT 5 Port 1
  Restart driver (detach VFs -> restart with devcon -> attach VFs)

  BF-3 sometimes stops responding. need to run it multiple times!

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2020606/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to