Public bug reported:
SRU Justification:
[Impact]
Although the gpio-mlxbf2.c driver has already been upstreamed, it did not
include gpio interrupt handling. We recently upstreamed the latter and as
requested by maintainers, moved all gpio interrupt code from the mlxbf-gige
driver to the gpio-mlxbf2.c to be conform with linux standards.
IMPORTANT: during testing, make sure the latest UEFI (bootloader) is loaded on
top of these changes, otherwise both the gpio driver and mlxbf-gige driver will
fail to load.
[Fix]
* reverted 6 commits related to the gpio-mlxbf2 driver so that the canonical
changes are in sync with what is upstreamed.
* Cherry-picked 11 gpio-mlxbf2.c commits from the linux master branch. 10
commits are minor commits added by other maintainers. The 11th cherry-picked
commit is the one adding proper interrupt support in the gpio-mlxbf2.c driver.
The upstreamed version of the GPIO driver added back the dependency between the
mlxbf-gige driver and gpio-mlxbf2 driver.
* Added one commit on top of the above to add the driver version and fix the
SPDX Licence identifier.
* updated the UEFI ACPI table to reflect the above changes (so the bootloader
and the linux drivers need to be in sync)
* Following the generic way of writing a linux gpio driver, we created a
separate driver for power handling (low power and reboot) called pwr-mlxbf.c.
This driver has not been upstreamed yet but will take care of the GPIO7
software reset and the OCP3.0 GPIO low power mode. Previously all this code was
integrated within the gpio-mlxbf2.c driver.
[Test Case]
* oob_net0 coming up after several SW_RESET or reboot
* oob_net0 coming up after several powercycles
* oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
* rmmod/modprobe mlxbf_gige several times
* Test that GPIO7 reset still works on BlueSphere like boards
[Regression Potential]
Any of the test cases above could be impacted due to these changes.
** Affects: linux-bluefield (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-bluefield in Ubuntu.
https://bugs.launchpad.net/bugs/1965017
Title:
Sync up gpio interrupt handling with upstreamed version
Status in linux-bluefield package in Ubuntu:
New
Bug description:
SRU Justification:
[Impact]
Although the gpio-mlxbf2.c driver has already been upstreamed, it did not
include gpio interrupt handling. We recently upstreamed the latter and as
requested by maintainers, moved all gpio interrupt code from the mlxbf-gige
driver to the gpio-mlxbf2.c to be conform with linux standards.
IMPORTANT: during testing, make sure the latest UEFI (bootloader) is loaded
on top of these changes, otherwise both the gpio driver and mlxbf-gige driver
will fail to load.
[Fix]
* reverted 6 commits related to the gpio-mlxbf2 driver so that the canonical
changes are in sync with what is upstreamed.
* Cherry-picked 11 gpio-mlxbf2.c commits from the linux master branch. 10
commits are minor commits added by other maintainers. The 11th cherry-picked
commit is the one adding proper interrupt support in the gpio-mlxbf2.c driver.
The upstreamed version of the GPIO driver added back the dependency between the
mlxbf-gige driver and gpio-mlxbf2 driver.
* Added one commit on top of the above to add the driver version and fix the
SPDX Licence identifier.
* updated the UEFI ACPI table to reflect the above changes (so the bootloader
and the linux drivers need to be in sync)
* Following the generic way of writing a linux gpio driver, we created a
separate driver for power handling (low power and reboot) called pwr-mlxbf.c.
This driver has not been upstreamed yet but will take care of the GPIO7
software reset and the OCP3.0 GPIO low power mode. Previously all this code was
integrated within the gpio-mlxbf2.c driver.
[Test Case]
* oob_net0 coming up after several SW_RESET or reboot
* oob_net0 coming up after several powercycles
* oob_net0 coming up after pushing a new Ubuntu/CentOS/Yocto
* rmmod/modprobe mlxbf_gige several times
* Test that GPIO7 reset still works on BlueSphere like boards
[Regression Potential]
Any of the test cases above could be impacted due to these changes.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1965017/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
