Verification done for bionic-proposed.
There are no verification steps, but the description shows what to check for:
- It currently doesn't parse the downstream WHENCE.ubuntu file.
- Fix that and cleanup any errors flagged by the checker.
Note: these must be performed on the git repo per dep on `git ls-files`.
PS: Juergh, hope you don't mind someone else verifying this!
Otherwise, sorry, please feel free to revert the tag change.
bionic-updates:
---
$ git checkout Ubuntu-1.173.20
WHENCE.ubuntu? No.
$ strace -f -e openat -o open.log ./check_whence.py 2>/dev/null
$ grep WHENCE open.log
2725 openat(AT_FDCWD, "WHENCE", O_RDONLY) = 3
Clean of errors? No.
$ ./check_whence.py 2>&1 | awk '{ $2 = "FILE"; print $0 }' | sort | uniq -c
131 E: FILE listed in WHENCE does not exist
115 E: FILE not listed in WHENCE
bionic-proposed:
---
$ git checkout Ubuntu-1.173.21
WHENCE.ubuntu? Yes.
$ strace -f -e openat -o open.log ./check_whence.py 2>/dev/null
$ grep WHENCE open.log
2755 openat(AT_FDCWD, "WHENCE", O_RDONLY|O_CLOEXEC) = 3
2755 openat(AT_FDCWD, "WHENCE.ubuntu", O_RDONLY|O_CLOEXEC) = 3
Clean of errors? Yes.
$ ./check_whence.py 2>&1 | awk '{ $2 = "FILE"; print $0 }' | sort | uniq -c
$
What if we force one? It works.
$ vim WHENCE # remove last entry
$ git diff
diff --git a/WHENCE b/WHENCE
...
-
-Driver: ice - Intel(R) Ethernet Connection E800 Series
-
-File: intel/ice/ddp/ice-1.3.4.0.pkg
-Link: intel/ice/ddp/ice.pkg -> intel/ice/ddp/ice-1.3.4.0.pkg
-
-License: Redistributable. See LICENSE.ice for details
$ ./check_whence.py
E: LICENSE.ice not listed in WHENCE or WHENCE.ubuntu
E: intel/ice/ddp/ice-1.3.4.0.pkg not listed in WHENCE or WHENCE.ubuntu
E: intel/ice/ddp/ice.pkg not listed in WHENCE or WHENCE.ubuntu
** Tags added: verification-done-bionic
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-firmware in Ubuntu.
https://bugs.launchpad.net/bugs/1953587
Title:
Fix sanity checker and cleanup metadata
Status in linux-firmware package in Ubuntu:
New
Status in linux-firmware source package in Bionic:
Fix Committed
Status in linux-firmware source package in Focal:
Fix Released
Status in linux-firmware source package in Hirsute:
Fix Released
Status in linux-firmware source package in Impish:
Fix Released
Bug description:
The repo contains a checker script check_whence.py that checks WHENCE
data against present firmware files and flags missing files and
missing WHENCE entries. It currently doesn't parse the downstream
WHENCE.ubuntu file. Fix that and cleanup any errors flagged by the
checker.
[ Impact ]
None. These are packaging changes that are not visible to the end
user.
[ Where Problems Could Occur ]
None.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-firmware/+bug/1953587/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
