@ Brad please see response from Intel on your follow up on questions:

 (a) affect Nvidia's use of DPC / EDR, depending upon how their firmware is 
negotiating the control with the operating system, and 
Response: As per spec, platforms should rely on _OSC to negotiate PCIe 
capabilities ownership. So for new platforms NVDIA should start using_OSC 
instead of HEST table.

(b) affect our existing installed base platforms that currently end up 
negotiating one way, but end up with a different result under this patch.  
E.g., the platform advertises "firmware first" in the ACPI  HEST, but not via 
_OSC.  I think it is more likely that server class  systems will already do 
this correctly, and that embedded / "IoT" type devices are more likely to see 
an impact from this change.
Response: For existing platforms, since they don't align with spec, 
recommendation is using pci quirks to create exception for their use cases.

This is platform generic enhancement and can be tested on Intel
platforms.

There was a question also on Diagnostics:
EDR related error messages:
1. "Failed to install notify handler"
2. "Firmware failed to locate DPC port" (Issue with 0x0D _DSM)
3. "This device doesn't support DPC"
4. "Invalid DPC trigger"

EDR success messages:
1. "EDR event received" ( for receiving successful EDR event)
2. "device recovery successful" ( for successful recovery)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1885030

Title:
  [Intel] Add Error Disconnect Recover support

Status in intel:
  Won't Fix
Status in linux package in Ubuntu:
  Incomplete
Status in linux source package in Focal:
  Incomplete
Status in linux source package in Groovy:
  Incomplete

Bug description:
  As per the following PCIe spec ECNs, implement EDR support in Linux
  kernel and upstream it.

  https://members.pcisig.com/wg/PCI-SIG/document/14076

  https://members.pcisig.com/wg/PCI-SIG/document/12888

  Patchset (Merged 5.7 mainline):
  894020fdd88c PCI/AER: Rationalize error status register clearing
  ac1c8e35a326 PCI/DPC: Add Error Disconnect Recover (EDR) support
  aea47413e7ce PCI/DPC: Expose dpc_process_error(), dpc_reset_link() for use by 
EDR
  20e15e673b05 PCI/AER: Add pci_aer_raw_clear_status() to unconditionally clear 
Error Status
  27005618178e PCI/DPC: Cache DPC capabilities in pci_init_capabilities()
  e8e5ff2aeec1 PCI/ERR: Return status of pcie_do_recovery()
  b6cf1a42f916 PCI/ERR: Remove service dependency in pcie_do_recovery()
  be06c1b42eea PCI/DPC: Move DPC data into struct pci_dev
  6d2c89441571 PCI/ERR: Update error status after reset_link()
  b5dfbeacf748 PCI/ERR: Combine pci_channel_io_frozen cases

To manage notifications about this bug go to:
https://bugs.launchpad.net/intel/+bug/1885030/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to