** Also affects: ubuntu-fan (Ubuntu Artful)
Importance: Undecided
Status: New
** Also affects: ubuntu-fan (Ubuntu Zesty)
Importance: Undecided
Status: New
** Also affects: ubuntu-fan (Ubuntu Xenial)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to ubuntu-fan in Ubuntu.
https://bugs.launchpad.net/bugs/1728050
Title:
fanatic enable-fan does not clean up config after failed bringup
Status in ubuntu-fan package in Ubuntu:
In Progress
Status in ubuntu-fan source package in Xenial:
New
Status in ubuntu-fan source package in Zesty:
Fix Committed
Status in ubuntu-fan source package in Artful:
Fix Committed
Bug description:
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge.
However it is possible that this returns with an error and in that case fanatic
must undo previously done configuration changes or otherwise any following
attempt to run enable-fan will incorrectly believe the bridge is up and do
nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Note: It seems in Artful, the default for iptables is to wait until
the lock is released (without -w) so the test here won't work without
adding -w to all iptables calls in fanctl. :/
Regression potential:
Cleanup called only on failure and the used function is also used in fanatic
disable-fan. -> Low
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1728050/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
