This commit relates to the hw_variant, too. commit 9268834b60c0b08101c7a8522b6901cf4cd57a14 Author: Tedd Ho-Jeong An <tedd...@intel.com> Date: Mon Mar 6 15:38:26 2017 -0800
Bluetooth: Use switch statement for Intel hardware variants Multiple new hardware variants are planned and the simple if statement would get really complicated and unreadable. So instead replace it with a simple switch statement. The change is applied to both USB and UART. Based-on-patch-by: Marcel Holtmann <mar...@holtmann.org> Signed-off-by: Tedd Ho-Jeong An <tedd...@intel.com> Signed-off-by: Marcel Holtmann <mar...@holtmann.org> -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1705633 Title: [8087:0a2b] Failed to load bluetooth firmware(might affect some other Intel bt devices) Status in HWE Next: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: Confirmed Bug description: [Impact] After this linux-firmware bug[1] update the firmware files, it removes intel/ibt-11-16.{ddc,sfi} and add intel/ibt-12-16.{ddc,sfi}, but in btusb driver, it hardcoded the hw_variant as 11. So we got this kind of error after the linux-firmware package updated and lost the bt functions. [ 5.516003] Bluetooth: hci0: Minimum firmware build 1 week 10 2014 [ 5.516181] bluetooth hci0: Direct firmware load for intel/ibt-11-16.sfi failed with error -2 [ 5.516183] Bluetooth: hci0: Failed to load Intel firmware file (-2) [Fix] This patch uses a hw_variant variable to replace the hardcoded 11. [Test Case] Verified on the machine has this issue, and confirm this patch works. [Regression Potential] The hw_variant variable has shown up since kernel 3.10 in this commit dffd30e Bluetooth: Add support for Intel Bluetooth device [8087:07dc] So, we don't have to worry about old chips don't contains this info, since it exists and be used for a very long time. 1. https://bugs.launchpad.net/ubuntu/+source/linux- firmware/+bug/1686815 To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1705633/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp