Hi Johnny,

I left some comments in the review.

To reduce the number of plugins just extend the blacklist. But Id rather recommend to ship to many files than to few.

Cheers,

Hannah

On 07/09/2020 15:17, Johnny Jazeix wrote:
Hi,

pinging again for the issues as I didn't managed to solve them yet.

Thank you,

Johnny

Le dim. 2 août 2020 à 22:03, Johnny Jazeix <jaz...@gmail.com <mailto:jaz...@gmail.com>> a écrit :

    Hi,

    I'm trying to craft Marble and I have some issues:
    * Marble creates plugins that are installed to plugins/ folder.
    Due to
    
https://invent.kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304
    
<https://invent.kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304>
    (which is used for Qt plugins), they are moved to bin/. Is there a
    way to make a more selective choice to only move Qt plugins?

    * I created the package (see
    
https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/20/diffs
    
<https://invent.kde.org/packaging/craft-blueprints-kde/-/merge_requests/20/diffs>
    for the recipe) and there are a lot of unwanted files: mysql,
    msg*.exe, other executables... in
    C:\CraftRoot\build\kde\applications\marble\archive\bin that are
    shipped. Do you have an idea on where they come from and how to
    ignore them?
    Blacklisting with "bin\\(?!(msg*|test*|r*|mysql*)).*\.exe" does
    not work.

    * This is less important but when I "ctrl+C" craft, it still says
    I succeeded ;).

    I can also create bugs on bugs.kde if needed.

    Thank you,

    Johnny

Reply via email to