----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130141/#review103245 -----------------------------------------------------------
Besides the nitpick it looks good. Please apply the change and commit to 2017.05 and cherry-pick -x to master portage/win32libs/libcurl/libcurl.py (line 20) <https://git.reviewboard.kde.org/r/130141/#comment68692> pls use the sha256sum self.targetDigests[''] = ([''], CraftHash.HashAlgorithm.SHA256) - Hannah von Reth On May 25, 2017, 5:46 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130141/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 5:46 p.m.) > > > Review request for kdewin. > > > Repository: craft > > > Description > ------- > > Updating `portage/win32libs/libcurl/libcurl.py` to build the latest version > of curl/libcurl. > > > Diffs > ----- > > portage/win32libs/libcurl/libcurl.py 341551b70 > > Diff: https://git.reviewboard.kde.org/r/130141/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
