----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129807/#review101961 -----------------------------------------------------------
I'll deal with the feedback when I get back to my main dev machines. One reply though: ksvg2ico could be used anywhere to create favicon.ico files for webpages. A request: I've been tinkering a bit with KDEWin's png2ico on a Linux machine, as it doesn't contain any Win32 specific code. The idea was to add support for larger icon sizes than 48px, but there seems to be something in the ico writer that makes this impossible (or that's just wrong in general). Then I discovered icotools (http://www.nongnu.org/icoutils/), a project that has the big advantage of being maintained, something that cannot be said of neither png2ico utility. I'll attach a .ico file created from Karbon's pre-existing .png icon files, up to 1024. Can someone with a Windows dev setup please check if this icon works as an app icon in the existing build system? - René J.V. Bertin On Jan. 11, 2017, 9:15 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129807/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2017, 9:15 p.m.) > > > Review request for KDE Frameworks, kdewin and Christoph Feck. > > > Repository: kiconthemes > > > Description > ------- > > Recently I committed a few changes to `ecm_add_app_icon` that make use of the > fact that KIconThemes includes a `ksvg2icns` utility, making it possible to > generate an application icon from an SVG file instead of from a series of PNG > files. > > With the present patch I propose to add an updated and partly rewritten > version of the ageing `svg2ico` tool from the KDEWin project to KIconThemes. > The goal is to have a proper and up-to-date tool to generate application > icons from SVG on MS Windows too. > > I considered proposing it to KDEWin instead, but in the end I liked the idea > better to provide icon conversion utilities for Mac and Windows with a > framework, where they might also serve in a less KDE-centric context (and > cross-platform development). > I also played with the idea of integrating the png2ico step into the tool, > but noticed during testing that Matthias Benkmann's png2ico supports input > sizes up to 248x248 while KDEWin's png2ico is currently limited at 48x48 or > maybe even 32x32. Lacking a MSWin development system I'm not volunteering to > update that code. > > > Diffs > ----- > > src/CMakeLists.txt efba9e6 > src/tools/ksvg2ico/CMakeLists.txt PRE-CREATION > src/tools/ksvg2ico/ksvg2ico.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129807/diff/ > > > Testing > ------- > > On Mac OS X 10.9 with Qt 5.7.1 and KF5 5.29.0 . > > > File Attachments > ---------------- > > .ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with > Benkmann's png2ico > > https://git.reviewboard.kde.org/media/uploaded/files/2017/01/11/aa0973dc-1be8-4d36-82dc-8f7baa053fee__apps-calligrakarbon.ico > > > Thanks, > > René J.V. Bertin > >
