> On May 20, 2016, 8:39 a.m., René J.V. Bertin wrote: > > Looks good but I'll try to do a test-build during one of my next "lost > > moments". > > > > Is there a minimum required version for either of the parser/generators?
> Is there a minimum required version for either of the parser/generators? Not that I know of. - Pino ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95644 ----------------------------------------------------------- On May 20, 2016, 6:39 a.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 6:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > ------- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > ----- > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > ------- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
