----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127672/ -----------------------------------------------------------
Review request for kdewin and Phonon. Repository: phonon Description ------- s_pulseActive is used inside PulseSupport::isUsable but is declared under HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this method to always return false when we don't HAVE_PULSEAUDIO. Diffs ----- phonon/pulsesupport.cpp dd79204 Diff: https://git.reviewboard.kde.org/r/127672/diff/ Testing ------- It builds on windows after this patch, no further testing done. Thanks, Andrius da Costa Ribas
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
