----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127266/#review93185 -----------------------------------------------------------
Ship it! (Another approach would have been to rename the stuff in the code, it's not like it's public API.) - David Faure On March 3, 2016, 2:37 p.m., Thomas Friedrichsmeier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127266/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 2:37 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: khtml > > > Description > ------- > > Fix building with MinGW on Windows, by removing conflicting FOCUS_EVENT (also > "OPTIONAL" and "CreateEvent") defines. Note that there already is a similar > #undef in dom2_eventsimpl.h, but this is ineffective, if the Windows defines > are added after dom2_eventsimpl.h was (first) included. > > First, I tried solving this by shuffling around includes, but gave up on this > path after quite some trial and error. (Main route of inclusion for windows.h > seems to be khtml_part.h -> parts/browserextension.h -> Platform includes.) > > > Diffs > ----- > > src/ecma/kjs_dom.cpp e3fedad > src/ecma/kjs_html.cpp cc3c08a > src/html/html_baseimpl.cpp 539681c > src/html/html_elementimpl.cpp 7569192 > src/html/htmlparser.cpp 064b99b > src/xml/dom_docimpl.cpp 4f0be5c > > Diff: https://git.reviewboard.kde.org/r/127266/diff/ > > > Testing > ------- > > Now builds with MinGW. > > > Thanks, > > Thomas Friedrichsmeier > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
