----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127192/ -----------------------------------------------------------
Review request for kdewin. Repository: emerge Description ------- Not sure, whether this is actually intended (strictly speaking, it does match the terminology used in emerge), but it did come as a (negative) surprise to me: emerge --cleanbuild XY does _not_ clean everything in build\category\XY\work, but only the "real" build directory (with the compiler / release type specification) in there. This is ok for most (not all) source packages, but for other packages it means leaving a lot of cruft. _If_ this is actually the intended behavior, I'd want a --cleanwork action, in addition to this. Assuming the intended behavior is to clean everything in build\category\XY\work, this patch will do that. Patch also makes failed removals non-fatal, in case there are write-protected files, or some-such. Diffs ----- bin/Package/PackageBase.py 33247f4 bin/utils.py 5d160b6 Diff: https://git.reviewboard.kde.org/r/127192/diff/ Testing ------- Tested locally, and cleans the "work" directories for packages such as mysql-pkg, aspell, 7zip, etc., that were not cleaned, before. Thanks, Thomas Friedrichsmeier
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
