----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127177/ -----------------------------------------------------------
Review request for KDE Frameworks and kdewin. Repository: ki18n Description ------- Fix compilation on Windows with MSVC. a) MSVC accepts declspec at global scope, only. b) QStringLiteral does not work with concatenated literals in MSVC (see http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/). Since the occurences seem to be mostly for debugging, going through QString::fromLatin1() in these cases should not hurt much. Diffs ----- src/kcatalog.cpp 083443d src/ktranscript.cpp 72c3755 Diff: https://git.reviewboard.kde.org/r/127177/diff/ Testing ------- Now builds with MSVC 2013. No other compilers and no other platforms tested for this patch. Thanks, Thomas Friedrichsmeier
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
