----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126560/#review90494 -----------------------------------------------------------
bin/BuildSystem/CMakeBuildSystem.py (line 32) <https://git.reviewboard.kde.org/r/126560/#comment61880> Could be simplified: `... + " Win64" if compiler.isX64() else ""` Rest looks good to me, nice. - Kevin Funk On Dec. 29, 2015, 1:37 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126560/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 1:37 p.m.) > > > Review request for kdewin, Kevin Funk, Patrick Spendrin, and Hannah von Reth. > > > Repository: emerge > > > Description > ------- > > Add support for building stuff using msbuild tool and Visual Studio CMake > generator. > > > Diffs > ----- > > bin/BuildSystem/CMakeBuildSystem.py 1eda47c > > Diff: https://git.reviewboard.kde.org/r/126560/diff/ > > > Testing > ------- > > Built kdevplatform and kdevelop with this patch. > > > Thanks, > > Gleb Popov > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
