----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/#review86755 -----------------------------------------------------------
Ship it! +1 from my side, seems like a nobrainer to me. - Milian Wolff On Oct. 12, 2015, 8:10 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125612/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 8:10 p.m.) > > > Review request for KDE Frameworks, kdewin and David Faure. > > > Repository: kservice > > > Description > ------- > > Make doctools optional to avoid needing them just to deploy kservice on > win/mac. > > If this is OK for this framework, I would apply the same logic to others, too. > > doctools is all nice, but just for getting the libraries built it is a bit > heavy, given nothing of its dependencies ships with Windows. > > > Diffs > ----- > > CMakeLists.txt 90cd5c5 > > Diff: https://git.reviewboard.kde.org/r/125612/diff/ > > > Testing > ------- > > make install did still create docs if doctools is around > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
