On 12 October 2015 at 08:33, Martin Graesslin <mgraess...@kde.org> wrote: > Hi frameworks and windows devs, > > from the release announcement of the latest frameworks release I learned that > there were multiple changes to disable finding X11 on Windows (e.g. [1]). I > think such changes are wrong and I have spoken against such changes (they are > wrong, CMake supports disabling modules without checking in code!) in the past > multiple times when I was aware of them (please include me in any reviews > touching X11). > > Given that we came up with a good solution for OSX directly in ECM [2]. Can we > get a similar solution for Windows? Then we can stop to patch random > frameworks. >
Hi Martin,good point. The difference is that KDE on Mac developer(s) prefer to support X11, and I am not sure anyone wants to spend precious time for supporting X11 on Windows. I am not, and I would be assuming WIN32 => NOT X11 in code I maintain. So if this is consistent with general direction, equivalent of APPLE_FORCE_X11 for windows makes no sense. So the case for Windows in KDECMakeSettings.cmake could be simpler, but yes, it's needed. Please give me some time for that. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows