----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124818/#review84087 -----------------------------------------------------------
That's a sync from kdewin.git I presume? portage/win32libs/shared-mime-info/dirent.h (line 33) <https://git.reviewboard.kde.org/r/124818/#comment58229> Is that include even used? (Doesn't look like.) If not, please remove it in kdewin, also remove lock.h from this diff again. portage/win32libs/shared-mime-info/kdewin_export.h (line 1) <https://git.reviewboard.kde.org/r/124818/#comment58228> Should get rid off that file again. The CMakeLists.txt defines `KDEWIN_EXPORT=` - Kevin Funk On Aug. 20, 2015, 9:36 a.m., arrowdodger arrowdodger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124818/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 9:36 a.m.) > > > Review request for kdewin. > > > Repository: emerge > > > Description > ------- > > VS was picking wrong function types for opendir/readdir because there was no > prototypes for them in dirent.h, which lead to crash. > The second crash was due to writing 8-byte intptr_t value returned by > _findfirst() into a 4-byte long variable. > No idea how it was working before. > > > Diffs > ----- > > portage/win32libs/shared-mime-info/dirent.h b98296a > portage/win32libs/shared-mime-info/dirent.c 2ca945a > portage/win32libs/shared-mime-info/kdewin_export.h PRE-CREATION > portage/win32libs/shared-mime-info/lock.h PRE-CREATION > portage/win32libs/shared-mime-info/shared-mime-info.py 6eda428 > > Diff: https://git.reviewboard.kde.org/r/124818/diff/ > > > Testing > ------- > > Running `update-mime-database KDevelop/share/mime` does not crash now. > > > Thanks, > > arrowdodger arrowdodger > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
