> On April 3, 2015, 5:58 p.m., Andrius da Costa Ribas wrote: > > cmake/uriencode.cmake, line 15 > > <https://git.reviewboard.kde.org/r/120648/diff/2/?file=320784#file320784line15> > > > > I've tried changing this to: > > > > execute_process(COMMAND perl -MURI::Escape -e "print > > uri_escape_utf8(\"${escaped_uri}\", \"^A-Za-z0-9\\-\\._~\\/\\\\:\");" > > (...) > > > > it works here, but I'm not sure if it'd be the proper fix. > > Patrick von Reth wrote: > ah that whas the error, thanks I finally can compile kdoctools (atleast > locally ) again > > Marko Käning wrote: > Has this already been committed, or should this RR still considered to be > re-opened? > > Luigi Toscano wrote: > No reopen, it was submitted. No, it was not committed, I'd like to > understand the implication of the patch.
Thanks for clarifying. BTW, thanks to Scarlett's progress on the new CI system it looks like we might soon be able to check whether this works also reliably on OSX when installing the files in space-containing paths. - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review78445 ----------------------------------------------------------- On Feb. 28, 2015, 11:02 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 11:02 p.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, > and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on > kdelibs4support. > > > Diffs > ----- > > cmake/uriencode.cmake PRE-CREATION > src/CMakeLists.txt 341ecf4 > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
