> On Jan. 11, 2015, 10:16 p.m., Ian Wadham wrote: > > This part of KDE desktop software is not ported to Apple OS X by the > > MacPorts group. People use Apple's battery-monitoring facility. Thanks > > anyway, Kai... :-) > > Nicolás Alvarez wrote: > Solid battery support isn't just for Plasma's battery indicator. There > are applications that disable some stuff if the computer is running on > batteries, for example. > > Ian Wadham wrote: > Hmmmm! Can you give us some examples of which apps those are, so that we > can watch out for them? > > KDE apps that require behind-the-scenes desktop facilities have been a > leading cause of problems in KDE on the Apple OS X platform for several > years, but our group on KDE-Mac has already dealt with quite a few during the > past year. KDE 4 apps are now integrating much better with the Apple desktop > than they did before, and we are working towards KF5/Frameworks and an Apple > OS X CI facility on KDE servers. > > Kai Uwe Broulik wrote: > Guys, this is just a behind the scenes library with no daemon(!) that > queries the native OS API for information, so when you ask for battery > percentage you get that info the same way, no matter on which platform you > are on. > > Ian Wadham wrote: > > you get that info the same way, no matter on which platform you are on. > > How do you know? What do you want us to test? How can we test it? Is this > Frameworks/KF5 stuff, or can we test it on KDE 4 apps with kdelibs 4 and Qt 4?
@Kai: the IOKit implementation is empty, just returns 0. If all platforms do that, then yeah, one gets the same info the same way, no matter the platform ^^ - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121992/#review73785 ----------------------------------------------------------- On Jan. 11, 2015, 5:41 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121992/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2015, 5:41 p.m.) > > > Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl. > > > Repository: solid > > > Description > ------- > > To properly calculate cumulative values we need to know the actual Wh values > of the batteries (deducing it from the current energy and percentage or > capacity produces significant rounding errors). > > > Diffs > ----- > > src/solid/devices/frontend/battery.h 4c3c3f7 > src/solid/devices/frontend/battery.cpp 7b95fc9 > src/solid/devices/ifaces/battery.h 055af62 > src/solid/devices/backends/win/winbattery.h 5dfe7c7 > src/solid/devices/backends/win/winbattery.cpp 95dbbb3 > src/solid/devices/backends/iokit/iokitbattery.h ccf6b20 > src/solid/devices/backends/upower/upowerbattery.h 0f0c7b6 > src/solid/devices/backends/upower/upowerbattery.cpp 7c1689e > src/solid/devices/backends/hal/halbattery.h 0d91009 > src/solid/devices/backends/hal/halbattery.cpp 24dde4b > src/solid/devices/backends/fakehw/fakebattery.h 3066f24 > src/solid/devices/backends/fakehw/fakebattery.cpp f90cb76 > > Diff: https://git.reviewboard.kde.org/r/121992/diff/ > > > Testing > ------- > > energyFull and energyFullDesign report correct values on UPower here. I > implemented it for HAL and Windows as well (and IOKit stubs) but I cannot > test these, hence adding kdewin and kde-mac groups. Also, we should really > add Q_DECL_OVERRIDE all over the place since adding new methods at 5 > different places is quite error-prone. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows