----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/#review72855 -----------------------------------------------------------
Ship it! Unfortunate to replace the switch-case, but I don't see a better solution either => Go for it. - Kevin Funk On Oct. 30, 2014, 1:35 a.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120877/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 1:35 a.m.) > > > Review request for kdewin and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder > as a compile-time const expression (error C2051: case expression not constant) > > > Diffs > ----- > > src/plasma/private/framesvg_helpers.h 5b96cd5 > > Diff: https://git.reviewboard.kde.org/r/120877/diff/ > > > Testing > ------- > > Builds with MSVC 2013 64bit. > > framesvg related tests pass, other unrelated tests still fail. > > Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master > Start 1: plasma-dialogqmltest > 1/10 Test #1: plasma-dialogqmltest ...............***Failed 1.15 sec > Start 2: plasma-fallbackpackagetest > 2/10 Test #2: plasma-fallbackpackagetest ......... Passed 0.16 sec > Start 3: plasma-packagestructuretest > 3/10 Test #3: plasma-packagestructuretest ........***Failed 0.19 sec > Start 4: plasma-packageurlinterceptortest > 4/10 Test #4: plasma-packageurlinterceptortest ... Passed 0.12 sec > Start 5: plasma-pluginloadertest > 5/10 Test #5: plasma-pluginloadertest ............ Passed 1.44 sec > Start 6: plasma-framesvgtest > 6/10 Test #6: plasma-framesvgtest ................ Passed 0.64 sec > Start 7: coronatest > 7/10 Test #7: coronatest .........................***Failed 0.16 sec > Start 8: plasma-storagetest > 8/10 Test #8: plasma-storagetest .................***Failed 0.12 sec > Start 9: plasma-sortfiltermodeltest > 9/10 Test #9: plasma-sortfiltermodeltest ......... Passed 0.14 sec > Start 10: i18ndcheck > Could not find executable SH-NOTFOUND > Looked in the following places: > SH-NOTFOUND > SH-NOTFOUND.exe > Release/SH-NOTFOUND > Release/SH-NOTFOUND.exe > Debug/SH-NOTFOUND > Debug/SH-NOTFOUND.exe > MinSizeRel/SH-NOTFOUND > MinSizeRel/SH-NOTFOUND.exe > RelWithDebInfo/SH-NOTFOUND > RelWithDebInfo/SH-NOTFOUND.exe > Deployment/SH-NOTFOUND > Deployment/SH-NOTFOUND.exe > Development/SH-NOTFOUND > Development/SH-NOTFOUND.exe > Unable to find executable: SH-NOTFOUND > 10/10 Test #10: i18ndcheck .........................***Not Run 0.00 sec > > 50% tests passed, 5 tests failed out of 10 > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
