> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > <https://git.reviewboard.kde.org/r/121575/diff/1/?file=333638#file333638line14> > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform library (like now proposed in kdeclarative) if it > > has a huge if not win32 block. > > Marco Martin wrote: > ah, doesn't support windows at all? even for libplasma isn't that good > then. > how much boilerplate would be needed to not use it for the graph thing? > > Jan Kundrát wrote: > There are some remarks about win32 at https://github.com/anholt/libepoxy > and their release page contains a "win32 version", so I think there's at > least some upstream support. The "if not block" Martin mentioned exists in > the CMakeLists.txt. > > Marco Martin wrote: > ok, so to see if kde on windows people can make it work, the if may be > removed > > Martin Gräßlin wrote: > yes exactly: the library in itself is available on Windows, just the > cmake is insufficient. But I do not know what the implications would be for > things like angle.
There are MSVC fixes for libepoxy on github, but anholt hasn't had the time to review and merge them yet. - Fredrik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121575/#review72229 ----------------------------------------------------------- On Dec. 18, 2014, 3:37 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121575/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2014, 3:37 p.m.) > > > Review request for KDE Frameworks, kdewin, kwin, and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > Both Plasma and KWin now depend from the epoxy opengl library. > So would be better to have the necessary cmake stuff in ecm instead of having > it copied in the two repos. > This is the file coming from KWin > > > Diffs > ----- > > find-modules/Findepoxy.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121575/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
