> On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: > > This breaks the kde4 build as ECM is not being used there and > > generate_export_header is not available without ECM. > > Andrius da Costa Ribas wrote: > generate_export_header isn't in ECM, but in cmake itself > (http://www.cmake.org/cmake/help/v3.0/module/GenerateExportHeader.html). Does > kde4 required cmake version not support it? Should I revert this commit?
Ah, I was not aware of that. So the solution probably is to move the include(GenerateExportheader) line outside the if-else for kf5/kde4 - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70761 ----------------------------------------------------------- On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121083/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 10:47 p.m.) > > > Review request for kde-workspace and kdewin. > > > Repository: oxygen > > > Description > ------- > > These files currently use > > ``` > __attribute__((visibility("..."))) > ``` > > which doesn't work on MSVC. > > > Diffs > ----- > > liboxygen/oxygen_config_export.h 02ea29d > liboxygen/oxygen_export.h b8877a0 > liboxygen/CMakeLists.txt 69b7bd2 > > Diff: https://git.reviewboard.kde.org/r/121083/diff/ > > > Testing > ------- > > Builds with msvc 2013 64bit > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
