----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ -----------------------------------------------------------
(Updated Nov. 20, 2014, 3:29 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description ------- Use CMake's generate_export_header whenever possible, and fix some inconsistent exports. Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). Diffs ----- dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 dolphin/src/views/dolphinitemlistview.h 7fd72e5 dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b dolphin/src/views/viewmodecontroller.h 9ea717a dolphin/src/views/viewproperties.h d3ea428 keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 keditbookmarks/main.cpp bc64193 konqueror/client/kfmclient.cpp 276452b konqueror/src/CMakeLists.txt 6831c88 konqueror/src/konq_statusbarmessagelabel.h a115d39 konqueror/src/konqmain.cpp 7a73231 konqueror/src/konqprivate_export.h 2dec78b dolphin/src/libdolphin_export.h ff0f125 dolphin/src/main.cpp 91d32a0 dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 dolphin/src/CMakeLists.txt c074908 dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 dolphin/src/kitemviews/kitemlistcontroller.h 99df531 dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 dolphin/src/kitemviews/kitemlistheader.h fe2d0ac dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e dolphin/src/kitemviews/kitemlistview.h cc0754f dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 dolphin/src/kitemviews/kitemlistwidget.h 07fc789 dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 dolphin/src/kitemviews/kstandarditem.h 59190bf dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 Diff: https://git.reviewboard.kde.org/r/121078/diff/ Testing ------- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
