----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68696 -----------------------------------------------------------
cmake/uriencode.cmake <https://git.reviewboard.kde.org/r/120648/#comment47898> You may want to consider using `string(REPLACE)` to escape double-quote chars in `${_original_uri}`, like string(REPLACE "\"" "\\"" escaped_uri "${${_original_uri}}") and then use `${escaped_uri}` in the perl script. src/CMakeLists.txt <https://git.reviewboard.kde.org/r/120648/#comment47897> You've already included it above... - Alex Merry On Oct. 18, 2014, 3:50 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120648/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2014, 3:50 p.m.) > > > Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, > and kdewin. > > > Repository: kdoctools > > > Description > ------- > > The URI need to be encoded, because some valid characters for > filenames are not valid according RFC 2396. > Easy way to trigger the issue: when the path contains spaces, > as it happens on MacOSX builds. > > See also https://git.reviewboard.kde.org/r/120649/ for the twin review on > kdelibs4support. > > > Diffs > ----- > > src/CMakeLists.txt 341ecf4 > cmake/uriencode.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120648/diff/ > > > Testing > ------- > > It compiles, but I can't properly test Mac and Windows scenarios > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
