----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review16878 -----------------------------------------------------------
Ship it! Ah, yes, this is a porting error. KDE4 cmake stuff used to define Q_WS_* cmake variables, but nothing does that in KF5. I trust you that "WIN32" and "APPLE" are right here, no experience with that. However this should be fixed across the board, not just in kidletime: kdecore/CMakeLists.txt:if (NOT Q_OS_X11) // LOL that's a good one :-) kded/CMakeLists.txt:if (Q_OS_MAC) kded/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:else(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:endif(Q_OS_MAC AND MAC_USE_OSXKEYCHAIN) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_WIN) kdeui/CMakeLists.txt:endif (Q_OS_WIN) kdeui/CMakeLists.txt:if(Q_OS_MAC) kdeui/CMakeLists.txt:endif(Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:elseif (Q_OS_WIN) kdeui/CMakeLists.txt:else(Q_OS_WIN) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kdeui/CMakeLists.txt:if (Q_OS_MAC) kdeui/CMakeLists.txt:endif (Q_OS_MAC) kinit/CMakeLists.txt:if (Q_OS_MAC) kinit/CMakeLists.txt:else (Q_OS_MAC) kinit/CMakeLists.txt:endif (Q_OS_MAC) tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_MAC) tier1/kidletime/src/CMakeLists.txt:elseif (Q_OS_WIN) tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_MAC) tier1/kwindowsystem/src/CMakeLists.txt:if (Q_OS_WIN) - David Faure On Aug. 4, 2012, 9:57 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105868/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2012, 9:57 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Description > ------- > > Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE. > > > Diffs > ----- > > tier1/kidletime/src/CMakeLists.txt 973d623 > > Diff: http://git.reviewboard.kde.org/r/105868/diff/ > > > Testing > ------- > > Got undefined references before the fix. > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
