Rainer Hurling <rhur...@freebsd.org> has asked freebsd-kde (group) <k...@freebsd.org> for maintainer-approval: Bug 283794: audio/amarok: Ressurect KDE music player, update to v3.2.2, QT6 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283794
Attachment 257730: patch for amarok v3.2.2 for Qt6, v2 https://bugs.freebsd.org/bugzilla/attachment.cgi?id=257730&action=edit --- Comment #21 from Rainer Hurling <rhur...@freebsd.org> --- Created attachment 257730 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=257730&action=edit patch for amarok v3.2.2 for Qt6, v2 (In reply to Max Brazhnikov from comment #20) >LIB_DEPENDS= libdbus-1.so:devel/dbus \ >+ libKF6ColorScheme.so:x11-themes/kf6-kcolorscheme >This should be replaced with 'USE_KDE= colorscheme'. Done. >+USES= cmake compiler:c++11-lang cpe desktop-file-utils gettext gl \ >+ kde:6 mysql:client pkgconfig qt:6 shebangfix ssl xorg >I don't see where 'shebangfix' is used. It is really needed? Seems not. Done. >+post-install: >+ @${MKDIR} ${STAGEDIR}${PREFIX}/share/mime/packages >You probably won't need this and '@dir share/mime/packages' in the pkg-plist, >if you add 'USES= shared-mime-info'. Removed post-install target. Done. Many thanks for these valuable suggestions for improving the port. >Shall we continue review at Phabricator? In my opinion, the submitter (Martin Filla) should decide whether a review in the Phabricator makes sense here?
