https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283794
Rainer Hurling <rhur...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #257701|maintainer-approval?(kde@Fr |
Flags|eeBSD.org) |
Attachment #257701|0 |1
is obsolete| |
Attachment #257730| |maintainer-approval?(kde@Fr
Flags| |eeBSD.org)
--- Comment #21 from Rainer Hurling <rhur...@freebsd.org> ---
Created attachment 257730
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=257730&action=edit
patch for amarok v3.2.2 for Qt6, v2
(In reply to Max Brazhnikov from comment #20)
>LIB_DEPENDS= libdbus-1.so:devel/dbus \
>+ libKF6ColorScheme.so:x11-themes/kf6-kcolorscheme
>This should be replaced with 'USE_KDE= colorscheme'.
Done.
>+USES= cmake compiler:c++11-lang cpe desktop-file-utils gettext gl \
>+ kde:6 mysql:client pkgconfig qt:6 shebangfix ssl xorg
>I don't see where 'shebangfix' is used. It is really needed?
Seems not. Done.
>+post-install:
>+ @${MKDIR} ${STAGEDIR}${PREFIX}/share/mime/packages
>You probably won't need this and '@dir share/mime/packages' in the pkg-plist,
>if you add 'USES= shared-mime-info'.
Removed post-install target. Done.
Many thanks for these valuable suggestions for improving the port.
>Shall we continue review at Phabricator?
In my opinion, the submitter (Martin Filla) should decide whether a review in
the Phabricator makes sense here?
--
You are receiving this mail because:
You are on the CC list for the bug.
