Hi there
Thanks a lot :)
1) You can modify that "Created by line" to mention you :)
2) You could probably improve that Makefile a bit, by using FOO_CMAKE_BOOL
[1].
3) I'm personally also not a fan of the Makefile.common used in
digikam-kde4,
and now in this one too, it makes it more confusing to me [also it
contains kde4 bits].
If you wan't I can import it into plasma5/PORTS :)
mfg Tobias
[1]
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-cmake_bool
On 29 August 2016 at 06:46, Thomas Legg <tjl...@gmail.com> wrote:
> Would love some feedback, especially on the USES, KDE, and QT5 sections of
> Makefiles.
> https://github.com/thomaslegg/digikam-kf5
>
> This builds digikam 5.1.0 built around a mutt version of the area51 kf5
> branch. Mutt as I've rolled the kdepim back to 16.04 as 16.08 kdepim
> calendaring requires qt5-webengine, which seems like it's going to require
> a lot of work to port.
>
> If using digikam-kde4, I recommend moving the .db files out of your photo
> repo directories and letting digikam-kde5 build new ones. I haven't tested
> all of the digikam features so far, but it launches, indexes, builds
> thumbnails, displays photos, adds tags. More testing required and if anyone
> else gets this to build, I'd love feedback on your use.
>
> Thomas Legg
>
