On 2010-Mar-02, 15:30, Max Brazhnikov wrote: > On Tue, 2 Mar 2010 12:34:36 +0100, Pietro Cerutti wrote: > > Dear kde@, portmgr@, > > > > I would like to commit the attached patch [1], that allows a port > > using cmake to define the CMAKE_OFFSOURCE variable and have the > > cmake framework build the port out of source [2]. > > > > While this changes applies to Mk/, I don't see this as a sweeping > > commit, since the default behavior remains unchanged, unless a port > > explicitely sets the variable CMAKE_OFFSOURCE. > > > > Any objection? > > Pietro, have you looked how kde4.mk handles with out of source builds? > I would prefer to not introduce CMAKE_BINARY_PATH, instead redefine *_WRKSRC > accordingly when CMAKE_OUTSOURCE is set.
Fine to me. I have uploaded a revised patch not using CMAKE_BINARY_PATH and based on how kde4 handles out-of-source builds here: http://people.freebsd.org/~gahr/bsd.cmake.mk.diff Thanks for commenting on this one! -- Pietro Cerutti g...@gahr.ch PGP Public Key: http://gahr.ch/pgp
pgp6ZzWHjSbfE.pgp
Description: PGP signature
_______________________________________________ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
